Issue 2268001: Removes obsolete suppression rules for Bug 44879....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2268001: Removes obsolete suppression rules for Bug 44879.... (Closed)

Created:
10 years, 7 months ago by Hironori Bono

Modified:
9 years, 7 months ago

Reviewers:
arv (Not doing code reviews)

CC:
chromium-reviews, Timur Iskhodzhanov, stuartmorgan, pam+watch_chromium.org, Alexander Potapenko

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Removes obsolete suppression rules for Bug 44879. This change just removes obsolete suppression rules for Bug 44879, which is fixed by r48212. BUG=44879 TEST=keep valgrind bots green. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48466

Patch Set 1 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -14 lines)			Patch
	M	tools/valgrind/memcheck/suppressions.txt	View		1 chunk	+0 lines, -14 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

arv (Not doing code reviews)

10 years, 7 months ago (2010-05-26 16:48:02 UTC) #2

LGTM

erik



On Wed, May 26, 2010 at 02:32,  <hbono@chromium.org> wrote:
> Reviewers: arv,
>
> Description:
> Removes obsolete suppression rules for Bug 44879.
> This change just removes obsolete suppression rules for Bug 44879, which is
> fixed by r48212.
>
> BUG=44879
> TEST=keep valgrind bots green.
>
> Please review this at http://codereview.chromium.org/2268001/show
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     tools/valgrind/memcheck/suppressions.txt
>
>
> Index: tools/valgrind/memcheck/suppressions.txt
> ===================================================================
> --- tools/valgrind/memcheck/suppressions.txt    (revision 48240)
> +++ tools/valgrind/memcheck/suppressions.txt    (working copy)
> @@ -2932,20 +2932,6 @@
>    ...
>  }
>  {
> -   bug_44879
> -   Memcheck:Leak
> -   fun:_Znw*
> -   ...
> -
>
fun:_ZN85_GLOBAL__N_chrome_renderer_extensions_extension_process_bindings.cc_00000000_FEADAD0F13ExtensionImpl12StartRequestERKN2v89ArgumentsE
> -}
> -{
> -   bug_44879
> -   Memcheck:Leak
> -   fun:_Znw*
> -   ...
> -
>
fun:_ZN85_GLOBAL__N_chrome_renderer_extensions_extension_process_bindings.cc_00000000_F8ABDBBA13ExtensionImpl12StartRequestERKN2v89ArgumentsE
> -}
> -{
>    bug_44966
>    Memcheck:Addr8
>    fun:event_del
>
>
>

Expand Messages | Collapse Messages