Issue 2267003: Use different product IO for SxS in mini installer....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2267003: Use different product IO for SxS in mini installer.... (Closed)

Created:
10 years, 6 months ago by huanr

Modified:
9 years ago

Reviewers:
cpu_(ooo_6.6-7.5)

CC:
chromium-reviews, kuchhal

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Use different product IO for SxS in mini installer. BUG=44846 TEST=mini_installer --chrome-sxs Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48465

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -1 line)			Patch
M	chrome/installer/mini_installer/appid.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/installer/mini_installer/chrome_appid.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/installer/mini_installer/chrome_frame_appid.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/installer/mini_installer/mini_installer.cc	View	1	1 chunk	+11 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

cpu_(ooo_6.6-7.5)

10 years, 6 months ago (2010-05-28 00:47:15 UTC) #2

one comment, rest lgtm.

http://codereview.chromium.org/2267003/diff/1/5
File chrome/installer/mini_installer/mini_installer.cc (right):

http://codereview.chromium.org/2267003/diff/1/5#newcode159
chrome/installer/mini_installer/mini_installer.cc:159: if (!::lstrcmpi(args[i],
L"--chrome-sxs"))
I would do if (0 == ::lstcmpi()) instead

Expand Messages | Collapse Messages