Issue 2266003: X64: Many small tweaks and more usages of "load smi as int32".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2266003: X64: Many small tweaks and more usages of "load smi as int32". (Closed)

Created:
10 years, 7 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
William Hesse

CC:
v8-dev

Visibility:
Public.

Description

X64: Many small tweaks and more usages of "load smi as int32".

Patch Set 1 #

Total comments: 2

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+71 lines, -76 lines)			Patch
M	src/x64/assembler-x64.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/codegen-x64.cc	View	20 chunks	+61 lines, -71 lines	1 comment	Download
M	src/x64/ic-x64.cc	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	src/x64/macro-assembler-x64.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View	1 chunk	+5 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

William Hesse

10 years, 7 months ago (2010-05-27 08:36:03 UTC) #2

LGTM.

http://codereview.chromium.org/2266003/diff/1/3
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/2266003/diff/1/3#newcode11079
src/x64/codegen-x64.cc:11079: // boundary before starting rep movs. Copy
remaining characters after running
Where is the destination aligned to a 4-byte boundary before rep movs?

http://codereview.chromium.org/2266003/diff/1/5
File src/x64/macro-assembler-x64.cc (right):

http://codereview.chromium.org/2266003/diff/1/5#newcode577
src/x64/macro-assembler-x64.cc:577: movl(dst, Operand(src, kIntSize));
Is kIntSize really better than "4" here?  If anything ever changes, there is no
reason to think kIntSize will remain the correct value.

Expand Messages | Collapse Messages