Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2265002: Reapply 48271 with fix (again) (Closed)

Created:
10 years, 7 months ago by M-A Ruel
Modified:
9 years, 7 months ago
CC:
chromium-reviews, Nasser Grainawi
Visibility:
Public.

Description

Reapply 48271 for the third time with fix. """ Enable automatic command and one-liner doc. Reformat pydoc accordingly. Add parser as an argument and parse_args hook in preparation to move parse_args at the right place, inside the CMDxx functions. R.I.P. gclient_test.py """ original code review at: http://codereview.chromium.org/2253002 In addition: - Add more smoke tests: vars, hooks, runhooks - Bugs filed about misbehavior with git checkout - Fixed gclient runhooks TEST=smoke test BUG=23328 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48309

Patch Set 1 #

Patch Set 2 : Another fix + more smoke tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+306 lines, -1529 lines) Patch
M PRESUBMIT.py View 1 chunk +0 lines, -1 line 0 comments Download
M gclient.py View 1 16 chunks +123 lines, -211 lines 0 comments Download
M tests/fake_repos.py View 1 4 chunks +47 lines, -5 lines 0 comments Download
M tests/gclient_smoketest.py View 1 11 chunks +136 lines, -39 lines 0 comments Download
D tests/gclient_test.py View 1 chunk +0 lines, -1273 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
M-A Ruel
Please take a look at this review, I plan to add more smoke test with ...
10 years, 7 months ago (2010-05-26 15:50:11 UTC) #1
Mandeep Singh Baines
Nice cleanup. LGTM
10 years, 7 months ago (2010-05-26 17:43:08 UTC) #2
M-A Ruel
I had to revert because of an exception with runhooks. I added the corresponding options.deps_os ...
10 years, 7 months ago (2010-05-26 18:49:32 UTC) #3
msb
10 years, 7 months ago (2010-05-26 19:00:49 UTC) #4
LGTM

maruel@chromium.org (maruel@chromium.org) wrote:
> I had to revert because of an exception with runhooks. I added the  
> corresponding
> options.deps_os = None and a regression test. I reused the same review so 
> you
> could see the differences.
>
> http://codereview.chromium.org/2265002/show

Powered by Google App Engine
This is Rietveld 408576698