Add ppapi plugins to about:plugins

Add ppapi plugins to about:plugins

Querying the plugin path and actual mime type is moved from creation of the
WebPluginDelegate to creation of the WebPlugin.  This cleaned up some code.

R=jam
BUG=45289
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48484

[jam, 2010-05-27 23:36:49]

lgtm

http://codereview.chromium.org/2262002/diff/67001/68001
File chrome/browser/plugin_service.cc (right):

http://codereview.chromium.org/2262002/diff/67001/68001#newcode428
chrome/browser/plugin_service.cc:428: info.product_name =
plugins[i].path.BaseName().ToWStringHack();
what's the plan for getting a proper name in here?

[darin (slow to review), 2010-05-28 00:03:36]

On Thu, May 27, 2010 at 4:36 PM, <jam@chromium.org> wrote:

> lgtm
>
>
> http://codereview.chromium.org/2262002/diff/67001/68001
> File chrome/browser/plugin_service.cc (right):
>
> http://codereview.chromium.org/2262002/diff/67001/68001#newcode428
> chrome/browser/plugin_service.cc:428: info.product_name =
> plugins[i].path.BaseName().ToWStringHack();
> what's the plan for getting a proper name in here?


No plan since this is just for plugins registered via command line.  It is
just for testing purposes.  We can make some other explicit calls to
RegisterInternalPlugin (within this same function) for any ppapi plugins
that are not specified via command line.

-Darin



>
>
> http://codereview.chromium.org/2262002/show
>

[jam, 2010-05-28 17:48:25]

got it, thanks

On Thu, May 27, 2010 at 5:03 PM, Darin Fisher <darin@chromium.org> wrote:

> On Thu, May 27, 2010 at 4:36 PM, <jam@chromium.org> wrote:
>
>> lgtm
>>
>>
>> http://codereview.chromium.org/2262002/diff/67001/68001
>> File chrome/browser/plugin_service.cc (right):
>>
>> http://codereview.chromium.org/2262002/diff/67001/68001#newcode428
>> chrome/browser/plugin_service.cc:428: info.product_name =
>> plugins[i].path.BaseName().ToWStringHack();
>> what's the plan for getting a proper name in here?
>
>
> No plan since this is just for plugins registered via command line.  It is
> just for testing purposes.  We can make some other explicit calls to
> RegisterInternalPlugin (within this same function) for any ppapi plugins
> that are not specified via command line.
>
> -Darin
>
>
>
>>
>>
>> http://codereview.chromium.org/2262002/show
>>
>
>