Adding a TearDown() method to class LiveSyncTest.

Adding a TearDown() method to class LiveSyncTest.

The LiveSyncTest class derives from InProcessBrowserTest and overrides
the SetUp method to account for the case when a local sync server needs
to be started. However, there isn't a corresponding override for the
TearDown method that stops the local sync server. This changelist adds
an overload for TearDown that stops the local sync server if one was
started in SetUp.

BUG=45181
TEST=sync_integration_tests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48457

[ncarter (slow), 2010-05-27 00:17:05]

Nice find.

http://codereview.chromium.org/2260001/diff/1/2
File chrome/test/live_sync/live_sync_test.h (right):

http://codereview.chromium.org/2260001/diff/1/2#newcode70
chrome/test/live_sync/live_sync_test.h:70: ASCIIToWide(server_url))
Rather than checking the state of the command line here (and duplicating the
StringPrintf() pattern), could we set a bool member variable
started_local_test_server_  when we start the server?

[Raghu Simha, 2010-05-27 04:00:56]

http://codereview.chromium.org/2260001/diff/1/2
File chrome/test/live_sync/live_sync_test.h (right):

http://codereview.chromium.org/2260001/diff/1/2#newcode70
chrome/test/live_sync/live_sync_test.h:70: ASCIIToWide(server_url))
On 2010/05/27 00:17:06, nick wrote:
> Rather than checking the state of the command line here (and duplicating the
> StringPrintf() pattern), could we set a bool member variable
> started_local_test_server_  when we start the server?

Done.

[Raghu Simha, 2010-05-27 04:03:37]

Adding BUG and TEST tags.

[ncarter (slow), 2010-05-27 23:47:55]

LGTM