Issue 226: Make gcc 4.1 happy with NULL in EXPECT_EQ

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 226: Make gcc 4.1 happy with NULL in EXPECT_EQ (Closed)

Created:
12 years, 3 months ago by Michael Moss

Modified:
9 years, 7 months ago

Reviewers:
Dean McNamee, Evan Martin

CC:
chromium-reviews_googlegroups.com

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Make gcc 4.1 happy with NULL in EXPECT_EQ. This avoids warnings like: src/base/thread_local_unittest.cc:88: warning: passing NULL to non-pointer argument 3 of 'static testing::AssertionResult testing::internal::EqHelper<true>::Compare(const char*, const char*, const T1&, T2*) [with T1 = int, T2 = <unnamed>::ThreadLocalTesterBase]' Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=1716

Patch Set 1 #

Patch Set 2 : '' #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	base/thread_local_unittest.cc	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Michael Moss

12 years, 3 months ago (2008-09-04 07:46:20 UTC) #2

Discussed with Dean, and decided to switch back to EXPECT_EQ, forcing NULL to
pointer type. This is more consistent with other EXPECT_EQ uses in Chrome.

Expand Messages | Collapse Messages