Issue 2259004: If the current engine is removed, then switch to another engine automatically.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2259004: If the current engine is removed, then switch to another engine automatically. (Closed)

Created:
10 years, 7 months ago by James Su

Modified:
9 years, 7 months ago

Reviewers:
Yusuke Sato, satorux1

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@chromiumos-git/ibus.git

Visibility:
Public.

Description

If the current engine is removed, then switch to another engine automatically. BUG=http://crosbug.com/3577 TEST=manual test.

Patch Set 1 #

Total comments: 1

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+128 lines, -70 lines)			Patch
	M	bus/ibusimpl.c	View		10 chunks	+128 lines, -70 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

satorux1

10 years, 7 months ago (2010-05-27 05:29:02 UTC) #2

LGTM

http://codereview.chromium.org/2259004/diff/1/2
File bus/ibusimpl.c (right):

http://codereview.chromium.org/2259004/diff/1/2#newcode1101
bus/ibusimpl.c:1101: gchar *old_engine_name = NULL;
const gchar * if possible?

Expand Messages | Collapse Messages