Issue 2255006: StatefulMem* functions should be library functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2255006: StatefulMem* functions should be library functions. (Closed)

Created:
10 years, 6 months ago by Bill Richardson

Modified:
9 years, 6 months ago

Reviewers:
gauravsh

CC:
chromium-os-reviews_chromium.org, gauravsh

Base URL:
ssh://git@chromiumos-git/chromeos

Visibility:
Public.

Description

StatefulMem* functions should be library functions. We want the BIOS to implement the stub functions, but that shouldn't include our StatefulMem* functions. Also, we ensure that we don't accidently use native linux functions instead of the stub functions.

Patch Set 1 #

Total comments: 1

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+127 lines, -84 lines)			Patch
M	src/platform/vboot_reference/vboot_firmware/include/utility.h	View	2 chunks	+8 lines, -37 lines	0 comments	Download
M	src/platform/vboot_reference/vboot_firmware/lib/cryptolib/rsa_utility.c	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/platform/vboot_reference/vboot_firmware/lib/cryptolib/sha2.c	View	2 chunks	+2 lines, -2 lines	0 comments	Download
A	src/platform/vboot_reference/vboot_firmware/lib/include/stateful_util.h	View	1 chunk	+56 lines, -0 lines	1 comment	Download
A	src/platform/vboot_reference/vboot_firmware/lib/stateful_util.c	View	1 chunk	+55 lines, -0 lines	0 comments	Download
M	src/platform/vboot_reference/vboot_firmware/stub/utility_stub.c	View	2 chunks	+1 line, -42 lines	0 comments	Download
M	src/platform/vboot_reference/vfirmware/Makefile	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/platform/vboot_reference/vfirmware/firmware_image.c	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/platform/vboot_reference/vkernel/Makefile	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/platform/vboot_reference/vkernel/kernel_image.c	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

gauravsh

10 years, 6 months ago (2010-05-27 19:07:50 UTC) #2

lgtm

http://codereview.chromium.org/2255006/diff/1/5
File src/platform/vboot_reference/vboot_firmware/lib/include/stateful_util.h
(right):

http://codereview.chromium.org/2255006/diff/1/5#newcode54
src/platform/vboot_reference/vboot_firmware/lib/include/stateful_util.h:54: 
extra vertical space

Expand Messages | Collapse Messages