Issue 2254003: Changed values of Cloud Print GAIA service id and Talk service URL to product...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2254003: Changed values of Cloud Print GAIA service id and Talk service URL to product... (Closed)

Created:
10 years, 7 months ago by sanjeevr

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Changed values of Cloud Print GAIA service id and Talk service URL to production values. BUG=None. TEST=Test with production cloudprint service. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48494

Patch Set 1 #

Total comments: 2

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	chrome/service/cloud_print/cloud_print_consts.cc	View		1 chunk	+2 lines, -4 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

lgtm with comment http://codereview.chromium.org/2254003/diff/1/2 File chrome/service/cloud_print/cloud_print_consts.cc (right): http://codereview.chromium.org/2254003/diff/1/2#newcode28 chrome/service/cloud_print/cloud_print_consts.cc:28: const char kCloudPrintTalkServiceUrl[] = "http://www.google.com/cloudprint"; Not ...

10 years, 7 months ago (2010-05-27 21:28:47 UTC) #2

sanjeevr

10 years, 7 months ago (2010-05-27 22:05:08 UTC) #3

http://codereview.chromium.org/2254003/diff/1/2
File chrome/service/cloud_print/cloud_print_consts.cc (right):

http://codereview.chromium.org/2254003/diff/1/2#newcode28
chrome/service/cloud_print/cloud_print_consts.cc:28: const char
kCloudPrintTalkServiceUrl[] = "http://www.google.com/cloudprint";
On 2010/05/27 21:28:47, Marc-Antoine Ruel wrote:
> Not https?

No, this is just a string to identify the service sending the talk notification.
The server uses http.

Expand Messages | Collapse Messages