Coverity: Initialize statement_cache_ in the constructor....

chrome/browser/history/history_database.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/history/history_database.h"
 
 #include <algorithm>
 #include <set>
+#include <string>
 
 #include "base/file_util.h"
 #include "base/histogram.h"
 #include "base/rand_util.h"
 #include "base/string_util.h"
 #include "chrome/common/sqlite_utils.h"
 
 using base::Time;
 
 namespace history {
@@ skipping 28 matching lines @@
       visit_count.step() != SQLITE_ROW)
     return;
   UMA_HISTOGRAM_COUNTS("History.VisitTableCount", visit_count.column_int(0));
 }
 
 }  // namespace
 
 HistoryDatabase::HistoryDatabase()
     : transaction_nesting_(0),
       db_(NULL),
+      statement_cache_(NULL),
       needs_version_17_migration_(false) {
 }
 
 HistoryDatabase::~HistoryDatabase() {
 }
 
 InitStatus HistoryDatabase::Init(const FilePath& history_name,
                                  const FilePath& bookmarks_path) {
   // OpenSqliteDb uses the narrow version of open, indicating to sqlite that we
   // want the database to be in UTF-8 if it doesn't already exist.
@@ skipping 63 matching lines @@
   DCHECK(db_);
   if (transaction_nesting_ == 0) {
     int rv = sqlite3_exec(db_, "BEGIN TRANSACTION", NULL, NULL, NULL);
     DCHECK(rv == SQLITE_OK) << "Failed to begin transaction";
   }
   transaction_nesting_++;
 }
 
 void HistoryDatabase::CommitTransaction() {
   DCHECK(db_);
-  DCHECK(transaction_nesting_ > 0) << "Committing too many transactions";
+  DCHECK_GT(transaction_nesting_, 0) << "Committing too many transactions";
   transaction_nesting_--;
   if (transaction_nesting_ == 0) {
     int rv = sqlite3_exec(db_, "COMMIT", NULL, NULL, NULL);
     DCHECK(rv == SQLITE_OK) << "Failed to commit transaction";
   }
 }
 
 bool HistoryDatabase::RecreateAllTablesButURL() {
   if (!DropVisitTable())
     return false;
@@ skipping 11 matching lines @@
     return false;
 
   // We also add the supplementary URL indices at this point. This index is
   // over parts of the URL table that weren't automatically created when the
   // temporary URL table was
   CreateSupplimentaryURLIndices();
   return true;
 }
 
 void HistoryDatabase::Vacuum() {
-  DCHECK(transaction_nesting_ == 0) <<
+  DCHECK_EQ(0, transaction_nesting_) <<
       "Can not have a transaction when vacuuming.";
   sqlite3_exec(db_, "VACUUM", NULL, NULL, NULL);
 }
 
 bool HistoryDatabase::SetSegmentID(VisitID visit_id, SegmentID segment_id) {
   SQLStatement s;
   if (s.prepare(db_, "UPDATE visits SET segment_id = ? WHERE id = ?") !=
       SQLITE_OK) {
     NOTREACHED();
     return false;
@@ skipping 126 matching lines @@
       NULL, NULL, NULL);
 
   // Erase all the full text index files. These will take a while to update and
   // are less important, so we just blow them away. Same with the archived
   // database.
   needs_version_17_migration_ = true;
 }
 #endif
 
 }  // namespace history