Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 225019: Fix for crasher on toast UI... (Closed)

Created:
11 years, 3 months ago by cpu_(ooo_6.6-7.5)
Modified:
9 years, 7 months ago
Reviewers:
Miranda Callahan
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

Fix for crasher on toast UI - The order of: radio_button = new views::RadioButton(..) layout->AddView(radio_button) radio_button->SetChecked(true); Matters, if the last two statements are inverted we crash (??) BUG=none TEST=start chrome with --try-chrome-again=1 and it does not crash and you see a toast Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27101

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/first_run_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
cpu_(ooo_6.6-7.5)
To beng: The crash is in void RadioButton::SetChecked(bool checked) { if (checked == RadioButton::checked()) return; ...
11 years, 3 months ago (2009-09-23 22:29:13 UTC) #1
Miranda Callahan
11 years, 3 months ago (2009-09-23 22:31:11 UTC) #2
lgtm

On 2009/09/23 22:29:13, cpu wrote:
> To beng: 
> 
> The crash is in
> 
> void RadioButton::SetChecked(bool checked) {
>   if (checked == RadioButton::checked())
>     return;
>   if (!native_wrapper_->UsesNativeRadioButtonGroup() && checked) {
> 
> bang! because native_wrapper == 0

Powered by Google App Engine
This is Rietveld 408576698