Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 225018: Rebaseline tests according to changes upstream.... (Closed)

Created:
11 years, 3 months ago by dglazkov
Modified:
9 years, 6 months ago
Reviewers:
levin
CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org
Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Whoops. Removed extraneous changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+556 lines, -26 lines) Patch
M webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/multicol/float-multicol-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/multicol/float-multicol-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/multicol/positioned-with-constrained-height-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/multicol/positioned-with-constrained-height-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/table/fixed-table-with-percent-inside-percent-table-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/table/fixed-table-with-percent-inside-percent-table-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/table/fixed-table-with-percent-width-inside-auto-table-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/table/fixed-table-with-percent-width-inside-auto-table-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/table/fixed-table-with-percent-width-inside-div-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/table/fixed-table-with-percent-width-inside-div-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/table/fixed-table-with-percent-width-inside-fixed-width-table-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/table/fixed-table-with-percent-width-inside-fixed-width-table-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/table/fixed-table-with-small-percent-width-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/table/fixed-table-with-small-percent-width-expected.png View Binary file 0 comments Download
M webkit/data/layout_tests/platform/chromium-linux/LayoutTests/tables/mozilla/bugs/bug34176-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-linux/LayoutTests/tables/mozilla/bugs/bug34176-expected.png View Binary file 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/multicol/float-multicol-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/multicol/float-multicol-expected.png View Binary file 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/multicol/float-multicol-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/multicol/positioned-with-constrained-height-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/multicol/positioned-with-constrained-height-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/multicol/positioned-with-constrained-height-expected.txt View 1 chunk +412 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/table/fixed-table-with-percent-inside-percent-table-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/table/fixed-table-with-percent-inside-percent-table-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/table/fixed-table-with-percent-inside-percent-table-expected.txt View 1 chunk +17 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/table/fixed-table-with-percent-width-inside-auto-table-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/table/fixed-table-with-percent-width-inside-auto-table-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/table/fixed-table-with-percent-width-inside-auto-table-expected.txt View 1 chunk +19 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/table/fixed-table-with-percent-width-inside-div-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/table/fixed-table-with-percent-width-inside-div-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/table/fixed-table-with-percent-width-inside-div-expected.txt View 1 chunk +20 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.txt View 1 chunk +11 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/table/fixed-table-with-percent-width-inside-fixed-width-table-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/table/fixed-table-with-percent-width-inside-fixed-width-table-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/table/fixed-table-with-percent-width-inside-fixed-width-table-expected.txt View 1 chunk +27 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/table/fixed-table-with-small-percent-width-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/table/fixed-table-with-small-percent-width-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/table/fixed-table-with-small-percent-width-expected.txt View 1 chunk +19 lines, -0 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/tables/mozilla/bugs/bug34176-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/tables/mozilla/bugs/bug34176-expected.png View Binary file 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/tables/mozilla/bugs/bug34176-expected.txt View 1 chunk +9 lines, -9 lines 0 comments Download
M webkit/tools/layout_tests/test_expectations.txt View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
dglazkov
11 years, 3 months ago (2009-09-23 21:48:19 UTC) #1
levin
11 years, 3 months ago (2009-09-23 22:00:09 UTC) #2 
LGTM.

one nit below.

http://codereview.chromium.org/225018/diff/1/2
File webkit/tools/layout_tests/test_expectations.txt (right):

http://codereview.chromium.org/225018/diff/1/2#newcode2352
Line 2352: // WebKit update 48665:48679
This line is no longer needed.

Powered by Google App Engine
This is Rietveld 408576698