Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: src/arm/virtual-frame-arm.h

Issue 2249002: Fix jump targets on ARM to merge virtual frames (really this time).... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 10 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/arm/macro-assembler-arm.cc ('k') | src/arm/virtual-frame-arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/arm/virtual-frame-arm.h
===================================================================
--- src/arm/virtual-frame-arm.h (revision 4738)
+++ src/arm/virtual-frame-arm.h (working copy)
@@ -107,14 +107,14 @@
// Construct a virtual frame as a clone of an existing one.
explicit inline VirtualFrame(VirtualFrame* original);
- inline CodeGenerator* cgen();
+ inline CodeGenerator* cgen() const;
inline MacroAssembler* masm();
// The number of elements on the virtual frame.
- int element_count() { return element_count_; }
+ int element_count() const { return element_count_; }
// The height of the virtual expression stack.
- inline int height();
+ inline int height() const;
bool is_used(int num) {
switch (num) {
@@ -162,7 +162,7 @@
// Spill all values from the frame to memory.
void SpillAll();
- void AssertIsSpilled() {
+ void AssertIsSpilled() const {
ASSERT(top_of_stack_state_ == NO_TOS_REGISTERS);
ASSERT(register_allocation_map_ == 0);
}
@@ -184,7 +184,7 @@
// Make this virtual frame have a state identical to an expected virtual
// frame. As a side effect, code may be emitted to make this frame match
// the expected one.
- void MergeTo(VirtualFrame* expected);
+ void MergeTo(const VirtualFrame* expected, Condition cond = al);
// Detach a frame from its code generator, perhaps temporarily. This
// tells the register allocator that it is free to use frame-internal
@@ -426,13 +426,13 @@
int stack_pointer() { return element_count_ - 1; }
// The number of frame-allocated locals and parameters respectively.
- inline int parameter_count();
- inline int local_count();
+ inline int parameter_count() const;
+ inline int local_count() const;
// The index of the element that is at the processor's frame pointer
// (the fp register). The parameters, receiver, function, and context
// are below the frame pointer.
- inline int frame_pointer();
+ inline int frame_pointer() const;
// The index of the first parameter. The receiver lies below the first
// parameter.
@@ -448,10 +448,10 @@
// The index of the first local. Between the frame pointer and the
// locals lies the return address.
- inline int local0_index();
+ inline int local0_index() const;
// The index of the base of the expression stack.
- inline int expression_base_index();
+ inline int expression_base_index() const;
// Convert a frame index into a frame pointer relative offset into the
// actual stack.
@@ -469,9 +469,9 @@
// Emit instructions to get the top of stack state from where we are to where
// we want to be.
- void MergeTOSTo(TopOfStack expected_state);
+ void MergeTOSTo(TopOfStack expected_state, Condition cond);
- inline bool Equals(VirtualFrame* other);
+ inline bool Equals(const VirtualFrame* other);
friend class JumpTarget;
};
« no previous file with comments | « src/arm/macro-assembler-arm.cc ('k') | src/arm/virtual-frame-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698