Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: src/arm/ic-arm.cc

Issue 2249002: Fix jump targets on ARM to merge virtual frames (really this time).... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 10 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/codegen-arm.cc ('k') | src/arm/jump-target-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 561 matching lines...) Expand 10 before | Expand all | Expand 10 after
572 // instruction is located just after the call to the IC in the deferred code 572 // instruction is located just after the call to the IC in the deferred code
573 // handling the miss in the inlined code. After the nop1 instruction there is 573 // handling the miss in the inlined code. After the nop1 instruction there is
574 // a branch instruction for jumping back from the deferred code. 574 // a branch instruction for jumping back from the deferred code.
575 Address address_after_call = address + Assembler::kCallTargetAddressOffset; 575 Address address_after_call = address + Assembler::kCallTargetAddressOffset;
576 Instr instr_after_call = Assembler::instr_at(address_after_call); 576 Instr instr_after_call = Assembler::instr_at(address_after_call);
577 if (!Assembler::IsNop(instr_after_call, PROPERTY_ACCESS_INLINED)) { 577 if (!Assembler::IsNop(instr_after_call, PROPERTY_ACCESS_INLINED)) {
578 return false; 578 return false;
579 } 579 }
580 Address address_after_nop = address_after_call + Assembler::kInstrSize; 580 Address address_after_nop = address_after_call + Assembler::kInstrSize;
581 Instr instr_after_nop = Assembler::instr_at(address_after_nop); 581 Instr instr_after_nop = Assembler::instr_at(address_after_nop);
582 ASSERT(Assembler::IsBranch(instr_after_nop)); 582 // There may be some reg-reg move and frame merging code to skip over before
583 // the branch back from the DeferredReferenceGetKeyedValue code to the inlined
584 // code.
585 while (!Assembler::IsBranch(instr_after_nop)) {
586 address_after_nop += Assembler::kInstrSize;
587 instr_after_nop = Assembler::instr_at(address_after_nop);
588 }
583 589
584 // Find the end of the inlined code for handling the load. 590 // Find the end of the inlined code for handling the load.
585 int b_offset = 591 int b_offset =
586 Assembler::GetBranchOffset(instr_after_nop) + Assembler::kPcLoadDelta; 592 Assembler::GetBranchOffset(instr_after_nop) + Assembler::kPcLoadDelta;
587 ASSERT(b_offset < 0); // Jumping back from deferred code. 593 ASSERT(b_offset < 0); // Jumping back from deferred code.
588 *inline_end_address = address_after_nop + b_offset; 594 *inline_end_address = address_after_nop + b_offset;
589 595
590 return true; 596 return true;
591 } 597 }
592 598
(...skipping 1212 matching lines...) Expand 10 before | Expand all | Expand 10 after
1805 GenerateMiss(masm); 1811 GenerateMiss(masm);
1806 } 1812 }
1807 1813
1808 1814
1809 #undef __ 1815 #undef __
1810 1816
1811 1817
1812 } } // namespace v8::internal 1818 } } // namespace v8::internal
1813 1819
1814 #endif // V8_TARGET_ARCH_ARM 1820 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/arm/codegen-arm.cc ('k') | src/arm/jump-target-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698