X64: Make smi memory operations work directly on the embedded value.

X64: Make smi memory operations work directly on the embedded value.
Adds Operand-relative Operand constructor.

[William Hesse, 2010-05-26 08:13:24]

LGTM.

http://codereview.chromium.org/2242002/diff/1/2
File src/x64/assembler-x64.cc (right):

http://codereview.chromium.org/2242002/diff/1/2#newcode262
src/x64/assembler-x64.cc:262: // Write new operand with same registers, but with
modified displacement.
Insert blank line after reading and before writing, to separate the two parts of
the function.

http://codereview.chromium.org/2242002/diff/1/2#newcode263
src/x64/assembler-x64.cc:263: disp_value += offset;
The assert for no overflow could be added:
ASSERT(disp_value <= 0 || offset <= 0 || disp_value + offset > 0);
ASSERT(disp_value >= 0 || offset >=0 || disp_value + offset < 0);

http://codereview.chromium.org/2242002/diff/1/3
File src/x64/assembler-x64.h (right):

http://codereview.chromium.org/2242002/diff/1/3#newcode305
src/x64/assembler-x64.h:305: // don't overflow.
Add assert for no overflow in .cc file - see comment there.

[Lasse Reichstein, 2010-05-26 08:34:10]

http://codereview.chromium.org/2242002/diff/1/2
File src/x64/assembler-x64.cc (right):

http://codereview.chromium.org/2242002/diff/1/2#newcode262
src/x64/assembler-x64.cc:262: // Write new operand with same registers, but with
modified displacement.
On 2010/05/26 08:13:24, William Hesse wrote:
> Insert blank line after reading and before writing, to separate the two parts
of
> the function.

Done.

http://codereview.chromium.org/2242002/diff/1/2#newcode263
src/x64/assembler-x64.cc:263: disp_value += offset;
Assertion added.

http://codereview.chromium.org/2242002/diff/1/3
File src/x64/assembler-x64.h (right):

http://codereview.chromium.org/2242002/diff/1/3#newcode305
src/x64/assembler-x64.h:305: // don't overflow.
On 2010/05/26 08:13:24, William Hesse wrote:
> Add assert for no overflow in .cc file - see comment there.

Done.