chrome/browser/tab_contents/interstitial_page.cc - Issue 224023: Don't send tab switching/killing/creating keyboard accelerators to pages. Th...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/tab_contents/interstitial_page.cc

Issue 224023: Don't send tab switching/killing/creating keyboard accelerators to pages. Th... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: call Browser:IsReservedAccelerator from tab_contents_view.cc instead of each platform file Created 11 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/cocoa/browser_window_cocoa.mm ('K') | « chrome/browser/renderer_host/render_widget_host_view_gtk.cc ('k') | chrome/browser/tab_contents/tab_contents_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/tab_contents/interstitial_page.cc

===================================================================

--- chrome/browser/tab_contents/interstitial_page.cc (revision 27783)

+++ chrome/browser/tab_contents/interstitial_page.cc (working copy)

@@ -93,6 +93,7 @@

virtual void UpdateDragCursor(WebDragOperation operation);

virtual void GotFocus();

virtual void TakeFocus(bool reverse);

+ virtual bool IsReservedAccelerator(const NativeWebKeyboardEvent& event);

virtual void HandleKeyboardEvent(const NativeWebKeyboardEvent& event);

virtual void HandleMouseEvent();

virtual void HandleMouseLeave();

@@ -575,6 +576,11 @@

interstitial_page_->tab()->GetViewDelegate()->TakeFocus(reverse);

}

+bool InterstitialPage::InterstitialPageRVHViewDelegate::IsReservedAccelerator(

+ const NativeWebKeyboardEvent& event) {

+ return false;

void InterstitialPage::InterstitialPageRVHViewDelegate::HandleKeyboardEvent(

const NativeWebKeyboardEvent& event) {

if (interstitial_page_->tab() && interstitial_page_->tab()->GetViewDelegate())