Don't send tab switching/killing/creating keyboard accelerators to pages. Th...

chrome/browser/cocoa/browser_window_cocoa.mm

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/gfx/rect.h"
 #include "base/logging.h"
 #include "base/sys_string_conversions.h"
 #include "chrome/browser/bookmarks/bookmark_utils.h"
 #include "chrome/browser/cocoa/browser_window_cocoa.h"
 #import "chrome/browser/cocoa/browser_window_controller.h"
@@ skipping 302 matching lines @@
 }
 
 void BrowserWindowCocoa::ShowPageMenu() {
   // No-op. Mac doesn't support showing the menus via alt keys.
 }
 
 void BrowserWindowCocoa::ShowAppMenu() {
   // No-op. Mac doesn't support showing the menus via alt keys.
 }
 
+int BrowserWindowCocoa::GetCommandId(const NativeWebKeyboardEvent& event) {
+  // TODO(port): return the command id if this is a keyboard accelerator.
+  // CommandForKeyboardShortcut() doesn't have the full list.

[Nico, 2009/10/02 03:11:01]

Yes, that's because in cocoa most keyboard shortcuts are bound to menu items
which in turn are bound to "actions" (basically function pointers).

suzhe: I think this is ok, we can walk the menu and for all menu items that have
target commandDispatch: get the tag (which is the command id) and the
accelerator and use that to implement this function.

+  return -1;
+}
+
 void BrowserWindowCocoa::Observe(NotificationType type,
                                  const NotificationSource& source,
                                  const NotificationDetails& details) {
   switch (type.value) {
     // Only the key window gets a direct toggle from the menu.
     // Other windows hear about it from the notification.
     case NotificationType::BOOKMARK_BAR_VISIBILITY_PREF_CHANGED:
       [controller_ toggleBookmarkBar];
       break;
     default:
       NOTREACHED();  // we don't ask for anything else!
       break;
   }
 }
 
 void BrowserWindowCocoa::DestroyBrowser() {
   [controller_ destroyBrowser];
 
   // at this point the controller is dead (autoreleased), so
   // make sure we don't try to reference it any more.
 }