Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Side by Side Diff: chrome/browser/browser_window.h

Issue 224023: Don't send tab switching/killing/creating keyboard accelerators to pages. Th... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: call Browser:IsReservedAccelerator from tab_contents_view.cc instead of each platform file Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_BROWSER_WINDOW_H_ 5 #ifndef CHROME_BROWSER_BROWSER_WINDOW_H_
6 #define CHROME_BROWSER_BROWSER_WINDOW_H_ 6 #define CHROME_BROWSER_BROWSER_WINDOW_H_
7 7
8 #include "base/gfx/native_widget_types.h" 8 #include "base/gfx/native_widget_types.h"
9 #include "chrome/browser/tab_contents/navigation_entry.h" 9 #include "chrome/browser/tab_contents/navigation_entry.h"
10 10
11 class Browser; 11 class Browser;
12 class BrowserWindowTesting; 12 class BrowserWindowTesting;
13 class DownloadShelf; 13 class DownloadShelf;
14 class FindBar; 14 class FindBar;
15 class GURL; 15 class GURL;
16 class HtmlDialogUIDelegate; 16 class HtmlDialogUIDelegate;
17 class LocationBar; 17 class LocationBar;
18 class Profile; 18 class Profile;
19 class StatusBubble; 19 class StatusBubble;
20 class TabContents; 20 class TabContents;
21 class TabContentsContainer; 21 class TabContentsContainer;
22 class TemplateURL; 22 class TemplateURL;
23 class ToolbarView; 23 class ToolbarView;
24 struct NativeWebKeyboardEvent;
24 25
25 namespace gfx { 26 namespace gfx {
26 class Rect; 27 class Rect;
27 } 28 }
28 29
29 //////////////////////////////////////////////////////////////////////////////// 30 ////////////////////////////////////////////////////////////////////////////////
30 // BrowserWindow interface 31 // BrowserWindow interface
31 // An interface implemented by the "view" of the Browser window. 32 // An interface implemented by the "view" of the Browser window.
32 // 33 //
33 // NOTE: All getters except GetTabStrip() may return NULL. 34 // NOTE: All getters except GetTabStrip() may return NULL.
(...skipping 214 matching lines...) Expand 10 before | Expand all | Expand 10 after
248 const GURL& url, 249 const GURL& url,
249 const NavigationEntry::SSLStatus& ssl, 250 const NavigationEntry::SSLStatus& ssl,
250 bool show_history) = 0; 251 bool show_history) = 0;
251 252
252 // Shows the page menu (for accessibility). 253 // Shows the page menu (for accessibility).
253 virtual void ShowPageMenu() = 0; 254 virtual void ShowPageMenu() = 0;
254 255
255 // Shows the app menu (for accessibility). 256 // Shows the app menu (for accessibility).
256 virtual void ShowAppMenu() = 0; 257 virtual void ShowAppMenu() = 0;
257 258
259 // Returns the id of the keyboard accelerator associated with the given
260 // keyboard event if one exists, otherwise -1.
261 virtual int GetCommandId(const NativeWebKeyboardEvent& event) = 0;
262
258 // Construct a BrowserWindow implementation for the specified |browser|. 263 // Construct a BrowserWindow implementation for the specified |browser|.
259 static BrowserWindow* CreateBrowserWindow(Browser* browser); 264 static BrowserWindow* CreateBrowserWindow(Browser* browser);
260 265
261 // Construct a FindBar implementation for the specified |browser|. 266 // Construct a FindBar implementation for the specified |browser|.
262 static FindBar* CreateFindBar(Browser* browser_window); 267 static FindBar* CreateFindBar(Browser* browser_window);
263 268
264 protected: 269 protected:
265 friend class BrowserList; 270 friend class BrowserList;
266 friend class BrowserView; 271 friend class BrowserView;
267 virtual void DestroyBrowser() = 0; 272 virtual void DestroyBrowser() = 0;
(...skipping 21 matching lines...) Expand all
289 294
290 // Returns the TabContentsContainer. 295 // Returns the TabContentsContainer.
291 virtual views::View* GetTabContentsContainerView() const = 0; 296 virtual views::View* GetTabContentsContainerView() const = 0;
292 297
293 // Returns the ToolbarView. 298 // Returns the ToolbarView.
294 virtual ToolbarView* GetToolbarView() const = 0; 299 virtual ToolbarView* GetToolbarView() const = 0;
295 #endif 300 #endif
296 }; 301 };
297 302
298 #endif // CHROME_BROWSER_BROWSER_WINDOW_H_ 303 #endif // CHROME_BROWSER_BROWSER_WINDOW_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698