Issue 2239010: Use getfqdn() instead of gethostname()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2239010: Use getfqdn() instead of gethostname() (Closed)

Created:
10 years, 7 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Sigurður Ásgeirsson

CC:
chromium-reviews

Visibility:
Public.

Description

Use getfqdn() instead of gethostname() Otherwise it would return the naked host name most of the time, especially on Windows. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48432

Patch Set 1 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	breakpad.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Sigurður Ásgeirsson

10 years, 7 months ago (2010-05-27 17:59:36 UTC) #2

lgtm.

On Thu, May 27, 2010 at 1:07 PM, <maruel@chromium.org> wrote:

> Reviewers: Ruðrugis,
>
> Description:
> Use getfqdn() instead of gethostname()
>
> Otherwise it would return the naked host name most of the time, especially
> on
> Windows.
>
> Please review this at http://codereview.chromium.org/2239010/show
>
> Affected files:
>  M breakpad.py
>
>
> Index: breakpad.py
> diff --git a/breakpad.py b/breakpad.py
> index
>
356774d89bc9ee574edfb2fe4908adbc888093b7..6818c9e0e882986323d39bd4464d68da45dca7c3
> 100644
> --- a/breakpad.py
> +++ b/breakpad.py
> @@ -43,6 +43,6 @@ def CheckForException():
>
>
>  if (not 'test' in sys.modules['__main__'].__file__ and
> -    socket.gethostname().endswith('.google.com')):
> +    socket.getfqdn().endswith('.google.com')):
>   # Skip unit tests and we don't want anything from non-googler.
>   atexit.register(CheckForException)
>
>
>

Expand Messages | Collapse Messages