Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: third_party/hunspell/README.chromium

Issue 2239005: Merges our hunspell change to hunspell 1.2.10.... (Closed) Base URL: svn://chrome-svn.corp.google.com/chrome/trunk/deps/
Patch Set: '' Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/hunspell/google.patch » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/hunspell/README.chromium
===================================================================
--- third_party/hunspell/README.chromium (revision 50428)
+++ third_party/hunspell/README.chromium (working copy)
@@ -1,29 +1,15 @@
-This is a partial copy of Hunspell 1.1.5, with the following changes:
-* '#include "config.h"' removed from src/hunspell/hunspell.hxx
-* '#include "config.h"' removed from src/hunspell/license.hunspell
-* Two unreferenced local variables removed from src/hunspell/suggestmgr.cxx
-* src/hunspell/utf_info.cxx moved to src/hunspell/utf_info.hxx, and #include
- reference in src/hunspell/csutil.cxx changed accordingly
-* Change the input params of the constructors to receive a FILE* instead of
- a file path. This is required to use hunspell in the sandbox.
- The patch is in google.patch.
+This is a partial copy of Hunspell 1.2.10 with the following changes:
+* Remove '#include "config.h"' from src/hunspell/hunspell.hxx
+* Remove '#include "config.h"' from src/hunspell/license.hunspell
+* Change src/hunspell/filemgr.hxx and src/hunspell/filemgr.cxx to use
+ LineIterator.
+* Add ScropedHashEntry, which creates temporary hentry objects, to
+ src/hunspell/suggestmgr.cxx
+* Change the input params of the constructors to receive a BDICTReader instead
+ of a file path.
+The patch is in google.patch.
-The English dictionary distributed by Firefox has been checked in to the
-dictionaries directory. It has several additions over the default
-myspell/hunspell dictionary.
-
-* Workaround for non-ASCII characters
-
-Visual Studio on Japanese Windows assumes the source files to be
-encoded in Shift_JIS. The compiler is unhappy with non-ASCII letters
-in the source files of Hunspell. The same problem happens with other
-CJK Windows as well. Here is the workaround for this problem:
-
-Convert 8-bit bytes to hexadecimal escaped forms by
-
- % perl -i -De 's/([\x80-\xff])/sprintf("\\x%02x", $1)/ge' src/*.cxx
-
-
-Note that Hunspell upstream is going to fix this problem. We'll no
-longer need the workaround if the problem is fixed in the upstream.
-
+All dictionaries used by Chromium has been checked in to the
+'third_party/hunspell_dictionaries' directory. They have several additions over
+the default myspell/hunspell dictionaries.
+(See 'third_party/hunspell_dictionaries/README.chromium' for their details.)
« no previous file with comments | « no previous file | third_party/hunspell/google.patch » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698