Issue 2234009: set client state to kClientInitializing a little earlier in order to satisfy ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2234009: set client state to kClientInitializing a little earlier in order to satisfy ... (Closed)

Created:
10 years, 7 months ago by wjia(left Chromium)

Modified:
9 years, 7 months ago

Reviewers:
jiesun

CC:
chromium-reviews, scherkus (not reviewing), fbarchard, awong, Alpha Left Google

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

set client state to kClientInitializing a little earlier in order to satisfy pipeline checking Contributed by wjia@chromium.org BUG=none TEST=tested with omx_test on tegra Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48496

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	media/filters/omx_video_decode_engine.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

wjia(left Chromium)

We should think about how to sort out all those states next.

10 years, 7 months ago (2010-05-27 21:22:49 UTC) #1

jiesun

On 2010/05/27 21:22:49, wjia wrote: > We should think about how to sort out all ...

10 years, 7 months ago (2010-05-27 21:28:01 UTC) #2

wjia(left Chromium)

10 years, 7 months ago (2010-05-27 21:44:01 UTC) #3

Could you help me check in? Let's do the splitting next patch. We have lots of
TODO's.

On 2010/05/27 21:28:01, jiesun wrote:
> On 2010/05/27 21:22:49, wjia wrote:
> > We should think about how to sort out all those states next.
> 
> LGTM. 
> ideally we should split play() and init() as two functions of engine
interface.

Expand Messages | Collapse Messages