src/platform/vboot_reference/utility/include/kernel_utility.h - Issue 2234003: Change kernel vboot header layout and add support for separate header verification.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/platform/vboot_reference/utility/include/kernel_utility.h

Issue 2234003: Change kernel vboot header layout and add support for separate header verification. (Closed) Base URL: ssh://git@gitrw.chromium.org/chromiumos

Patch Set: add verifykernelheader(). rename old function to verifykernelkeyheader(). Created 10 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « src/platform/vboot_reference/tests/test_common.c ('k') | src/platform/vboot_reference/utility/kernel_utility.cc » ('j') | src/platform/vboot_reference/vkernel/kernel_image_fw.c » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/platform/vboot_reference/utility/include/kernel_utility.h

diff --git a/src/platform/vboot_reference/utility/include/kernel_utility.h b/src/platform/vboot_reference/utility/include/kernel_utility.h

index 16967adbdc2248fed065d9261cad35358e83a0aa..5b0cab398c5b0d52d332ed164a4bb341881edb5f 100644

--- a/src/platform/vboot_reference/utility/include/kernel_utility.h

+++ b/src/platform/vboot_reference/utility/include/kernel_utility.h

@@ -58,11 +58,6 @@ class KernelUtility {

std::string firmware_key_pub_file_;

std::string kernel_key_file_; // Private key for signing the kernel.

std::string kernel_key_pub_file_;

- std::string config_file_; // File containing kernel config options.

- // TODO(gauravsh): Currently this just fills in options.cmd_line in struct

- // KernelImage (from vkernel/kernel_image_fw.h). Ideally we'd like to have

- // a well defined config file format which is also backwards compatible with

- // Legacy BIOS boot loaders.

// Fields of a KernelImage. (read from the command line).

int header_version_;