Issue 2231002: complete 'cgpt show' and refactor for incoming commands.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2231002: complete 'cgpt show' and refactor for incoming commands. (Closed)

Created:
10 years, 7 months ago by Louis

Modified:
9 years, 4 months ago

Reviewers:
Bill Richardson

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@chromiumos-git/chromeos

Visibility:
Public.

Description

complete 'cgpt show' and refactor for incoming commands. Sorry for late. I spent some time to handle Guid endian issue and UTF16/UTF8 consversion. Also, refactored code for incoming commands.

Patch Set 1 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+538 lines, -122 lines)			Patch
M	src/platform/vboot_reference/cgptlib/cgptlib.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/platform/vboot_reference/cgptlib/cgptlib.c	View	10 chunks	+97 lines, -48 lines	0 comments	Download
M	src/platform/vboot_reference/cgptlib/cgptlib_internal.h	View	1 chunk	+8 lines, -5 lines	0 comments	Download
M	src/platform/vboot_reference/cgptlib/tests/cgptlib_test.c	View	4 chunks	+12 lines, -2 lines	0 comments	Download
M	src/platform/vboot_reference/utility/cgpt/Makefile	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/platform/vboot_reference/utility/cgpt/cgpt.h	View	2 chunks	+25 lines, -0 lines	0 comments	Download
M	src/platform/vboot_reference/utility/cgpt/cgpt.c	View	8 chunks	+159 lines, -5 lines	0 comments	Download
M	src/platform/vboot_reference/utility/cgpt/cgpt_attribute.c	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/platform/vboot_reference/utility/cgpt/cgpt_repair.c	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	src/platform/vboot_reference/utility/cgpt/cgpt_show.c	View	6 chunks	+221 lines, -61 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages