Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1660)

Issue 223027: Convert the BrowerThemeProvider pointer from being ref counted to (Closed)

Created:
11 years, 3 months ago by tony
Modified:
9 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Convert the BrowerThemeProvider pointer from being ref counted to not being ref counted. It's owned by the profile and it doesn't need to be ref counted. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27152

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -16 lines) Patch
M chrome/browser/browser_theme_provider.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/profile.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profile.cc View 3 chunks +4 lines, -7 lines 0 comments Download
M chrome/test/testing_profile.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/testing_profile.cc View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tony
11 years, 3 months ago (2009-09-24 20:52:59 UTC) #1
brettw
11 years, 3 months ago (2009-09-24 21:00:27 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698