Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: trychange.py

Issue 223024: Fix the prompt so the user can interact with svn. (Closed)
Patch Set: Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trychange.py
diff --git a/trychange.py b/trychange.py
index c99388d8b917dfd935970c2bef3afec8cf6546ce..0b3bef5337dae5222e28527b82de9226213df2d2 100755
--- a/trychange.py
+++ b/trychange.py
@@ -15,6 +15,7 @@ import optparse
import os
import shutil
import socket
+import subprocess
import sys
import tempfile
import traceback
@@ -317,11 +318,14 @@ def _SendChangeSVN(options):
try:
# Don't use '--non-interactive', since we want it to prompt for
# crendentials if necessary.
- command = ['svn', 'checkout', '--depth', 'empty',
+ command = ['svn', 'checkout', '--depth', 'empty', '-q',
options.svn_repo, temp_dir]
if options.email:
command += ['--username', options.email]
- RunCommand(command)
+ # Don't use RunCommand() since svn may prompt for information.
+ use_shell = sys.platform.startswith("win")
+ subprocess.Popen(command, shell=use_shell).communicate()
+
# TODO(maruel): Use a subdirectory per user?
current_time = str(datetime.datetime.now()).replace(':', '.')
file_name = (EscapeDot(options.user) + '.' + EscapeDot(options.name) +
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698