Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(939)

Unified Diff: src/platform/vboot_reference/vboot_firmware/lib/firmware_image_fw.c

Issue 2225005: New anti-rollback strategy (no TPM NVRAM write cycles for locking). (Closed) Base URL: ssh://git@chromiumos-git/chromeos
Patch Set: comment changes Created 10 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/platform/vboot_reference/vboot_firmware/lib/firmware_image_fw.c
diff --git a/src/platform/vboot_reference/vboot_firmware/lib/firmware_image_fw.c b/src/platform/vboot_reference/vboot_firmware/lib/firmware_image_fw.c
index 85b4d352c508c12d39ec0805b688567dc507933f..a8cb646a963280474d12c96d0930ad59209405ff 100644
--- a/src/platform/vboot_reference/vboot_firmware/lib/firmware_image_fw.c
+++ b/src/platform/vboot_reference/vboot_firmware/lib/firmware_image_fw.c
@@ -289,14 +289,11 @@ int VerifyFirmwareDriver_f(uint8_t* root_key_blob,
}
}
}
- /* Lock Firmware TPM rollback indices from further writes. */
- /* TODO(gauravsh): Figure out if these can be combined into one
- * 32-bit location since we seem to always use them together. This can help
- * us minimize the number of NVRAM writes/locks (which are limited over flash
- * memory lifetimes.
+ /* Lock Firmware TPM rollback indices from further writes. In this design,
+ * this is done by setting the globalLock bit, which is cleared only by
+ * TPM_Init at reboot.
*/
- LockStoredVersion(FIRMWARE_KEY_VERSION);
- LockStoredVersion(FIRMWARE_VERSION);
+ LockFirmwareVersions();
/* Determine which firmware (if any) to jump to.
*

Powered by Google App Engine
This is Rietveld 408576698