Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3110)

Unified Diff: chrome/browser/app_menu_model.h

Issue 2225003: Implement upgrade notifications.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/app_menu_model.h
===================================================================
--- chrome/browser/app_menu_model.h (revision 48146)
+++ chrome/browser/app_menu_model.h (working copy)
@@ -22,10 +22,11 @@
Browser* browser);
virtual ~AppMenuModel();
- // Override this to handle the sync menu item (whose label is
- // updated dynamically).
+ // Overridden from menus::SimpleMenuModel:
virtual bool IsLabelDynamicAt(int index) const;
virtual string16 GetLabelAt(int index) const;
+ virtual bool HasIcons() const { return true; }
+ virtual bool GetIconAt(int index, SkBitmap* icon) const;
// Build/update profile submenu. Return true if profiles submenu is built or
// updated. False otherwise.
@@ -37,7 +38,8 @@
bool ProfilesChanged(const std::vector<std::wstring>& profiles) const;
string16 GetSyncMenuLabel() const;
- bool IsSyncItem(int index) const;
+ string16 GetAboutEntryMenuLabel() const;
+ bool IsDynamicItem(int index) const;
// Contents of the profiles menu to populate with profile names.
scoped_ptr<menus::SimpleMenuModel> profiles_menu_contents_;

Powered by Google App Engine
This is Rietveld 408576698