Implement upgrade notifications....

chrome/browser/browser_shutdown.cc

-// Copyright (c) 2009 The Chromium Authors. All rights reserved.
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/browser_shutdown.h"
 
 #include <string>
 
 #include "app/resource_bundle.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/histogram.h"
 #include "base/path_service.h"
 #include "base/string_util.h"
 #include "base/thread.h"
 #include "base/time.h"
 #include "base/waitable_event.h"
 #include "build/build_config.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chrome_thread.h"
 #include "chrome/browser/dom_ui/chrome_url_data_manager.h"
 #include "chrome/browser/first_run.h"
 #include "chrome/browser/jankometer.h"
 #include "chrome/browser/metrics/metrics_service.h"
 #include "chrome/browser/plugin_process_host.h"
 #include "chrome/browser/pref_service.h"
 #include "chrome/browser/renderer_host/render_process_host.h"
 #include "chrome/browser/renderer_host/render_view_host.h"
 #include "chrome/browser/renderer_host/render_widget_host.h"
 #include "chrome/common/chrome_paths.h"
+#include "chrome/common/chrome_switches.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/chrome_plugin_lib.h"
 #include "net/dns_global.h"
 
 #if defined(OS_WIN)
 #include "chrome/browser/rlz/rlz.h"
 #endif
 
 using base::Time;
 using base::TimeDelta;
@@ skipping 80 matching lines @@
 
   if (shutdown_type_ > NOT_VALID && shutdown_num_processes_ > 0) {
     // Record the shutdown info so that we can put it into a histogram at next
     // startup.
     prefs->SetInteger(prefs::kShutdownType, shutdown_type_);
     prefs->SetInteger(prefs::kShutdownNumProcesses, shutdown_num_processes_);
     prefs->SetInteger(prefs::kShutdownNumProcessesSlow,
                       shutdown_num_processes_slow_);
   }
 
+  // Check local state for the restart flag so we can restart the session below.
+  bool restart_last_session = false;
+  if (prefs->HasPrefPath(prefs::kRestartLastSessionOnShutdown)) {
+    restart_last_session =
+        prefs->GetBoolean(prefs::kRestartLastSessionOnShutdown);
+    prefs->ClearPref(prefs::kRestartLastSessionOnShutdown);
+  }
+
   prefs->SavePersistentPrefs();
 
 #if defined(OS_WIN)
   // Cleanup any statics created by RLZ. Must be done before NotificationService
   // is destroyed.
   RLZTracker::CleanupRlz();
 #endif
 
   // The jank'o'meter requires that the browser process has been destroyed
   // before calling UninstallJankometer().
   delete g_browser_process;
   g_browser_process = NULL;
 
   // Uninstall Jank-O-Meter here after the IO thread is no longer running.
   UninstallJankometer();
 
   if (delete_resources_on_shutdown)
     ResourceBundle::CleanupSharedInstance();
 
 #if defined(OS_WIN)
   if (!Upgrade::IsBrowserAlreadyRunning() &&
       shutdown_type_ != browser_shutdown::END_SESSION) {
     Upgrade::SwapNewChromeExeIfPresent();
   }
+
+  if (restart_last_session) {
+    // Make sure to relaunch the browser with the same command line and add
+    // Restore Last Session flag if session restore is not set.
+    CommandLine command_line = CommandLine::FromString(
+        CommandLine::ForCurrentProcess()->command_line_string());
+    if (!command_line.HasSwitch(switches::kRestoreLastSession))
+      command_line.AppendSwitch(switches::kRestoreLastSession);
+    Upgrade::RelaunchChromeBrowser(command_line);

[Nico, 2010/08/27 05:14:09]

Isn't this very racy? RelaunchChromeBrowser() mostly just calls
base::LaunchApp() directly, which means we're basically hope that the current
process finishes fast enough before the new process starts up.

[Nico, 2010/08/27 05:17:15]

This might be the cause for http://crbug.com/50803 and possibly
http://crbug.com/49631

+  }
+#endif
+#if !defined(OS_WIN)
+  if (restart_last_session)
+    NOTIMPLEMENTED();
 #endif
 
   if (shutdown_type_ > NOT_VALID && shutdown_num_processes_ > 0) {
     // Measure total shutdown time as late in the process as possible
     // and then write it to a file to be read at startup.
     // We can't use prefs since all services are shutdown at this point.
     TimeDelta shutdown_delta = Time::Now() - shutdown_started_;
     std::string shutdown_ms = Int64ToString(shutdown_delta.InMilliseconds());
     int len = static_cast<int>(shutdown_ms.length()) + 1;
     FilePath shutdown_ms_file = GetShutdownMsPath();
@@ skipping 70 matching lines @@
 void SetTryingToQuit(bool quitting) {
   g_trying_to_quit = quitting;
 }
 
 bool IsTryingToQuit() {
   return g_trying_to_quit;
 }
 #endif
 
 }  // namespace browser_shutdown