Issue 2223003: Fix: make string indexing work with Infinity.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2223003: Fix: make string indexing work with Infinity. (Closed)

Created:
10 years, 7 months ago by Vitaly Repeshko

Modified:
9 years, 7 months ago

Reviewers:
antonm

CC:
v8-dev

Visibility:
Public.

Description

Fix: make string indexing work with Infinity. NumberToUint32 that I was trying to use maps -0 to +0 (as desired) but also maps +/-Infinity to +0, which made +/-Infinity a valid string index. I fixed it by introducing a new runtime function with the right semantics. TEST=LayoutTests/fast/js/char-at.html,mjsunit/string-charat.js Committed: http://code.google.com/p/v8/source/detail?r=4734

Patch Set 1 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -15 lines)			Patch
M	src/arm/codegen-arm.cc	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	src/ia32/codegen-ia32.cc	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	src/runtime.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/runtime.cc	View	1 chunk	+19 lines, -0 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	test/mjsunit/string-charat.js	View	2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

I esp. liked if (value == 0) value = 0 part.

Expand Messages | Collapse Messages