Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2222002: Unsigned warning fix - take 2 (Closed)

Created:
10 years, 7 months ago by Mike Belshe
Modified:
9 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Visibility:
Public.

Description

Enable warning 4389 as an error on windows builds. This will make windows builds more similar to linux/mac, which already treat signed/ unsigned equality comparisons as warnings (and hence errors). BUG=44471 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48395

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -162 lines) Patch
M app/os_exchange_data_provider_win.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M app/win/window_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M base/crypto/scoped_capi_types.h View 1 chunk +1 line, -1 line 0 comments Download
M base/event_trace_consumer_win_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/event_trace_controller_win_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M base/event_trace_provider_win_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/file_util_win.cc View 2 chunks +6 lines, -10 lines 0 comments Download
M base/iat_patch.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/lock_impl_win.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M base/scoped_bstr_win_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M base/thread_local.h View 2 chunks +2 lines, -2 lines 0 comments Download
M build/common.gypi View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/app/chrome_dll_main.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/automation/ui_controls_win.cc View 2 3 4 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/debugger/devtools_remote_listen_socket_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_uitest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/importer/importer_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/syncable/syncable.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/views/select_profile_dialog.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M chrome/installer/util/l10n_string_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome_frame/chrome_active_document.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome_frame/chrome_frame_activex.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome_frame/chrome_launcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome_frame/function_stub_unittest.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome_frame/html_utils.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M chrome_frame/test/chrome_frame_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/test/exception_barrier_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome_frame/test/html_util_unittests.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome_frame/test/perf/chrome_frame_perftest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome_frame/test/util_unittests.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome_frame/urlmon_url_request.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M gfx/icon_util.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/base/listen_socket_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/base/network_change_notifier_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/socket/tcp_client_socket_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/tools/dump_cache/cache_dumper.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M net/tools/dump_cache/upgrade.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M sandbox/src/file_policy_test.cc View 5 chunks +16 lines, -16 lines 0 comments Download
M sandbox/src/interception_unittest.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M sandbox/src/job_unittest.cc View 8 chunks +9 lines, -9 lines 0 comments Download
M sandbox/src/restricted_token_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M sandbox/src/win_utils_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M views/controls/table/table_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/default_plugin/plugin_database_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698