Issue 222031: Roll back Markus's CL ( http://codereview.chromium.org/196053)...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 222031: Roll back Markus's CL ( http://codereview.chromium.org/196053)... (Closed)

Created:
11 years, 3 months ago by jungshik at Google

Modified:
9 years, 7 months ago

Reviewers:
Markus (顧孟勤)

CC:
chromium-reviews_googlegroups.com, darin (slow to review), brettw, tim (not reviewing), Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Roll back Markus's CL ( http://codereview.chromium.org/196053) BUG=none TEST=UI test and valgrind test pass TBR=markus Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27160

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -58 lines)			Patch
M	base/time.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	base/time.cc	View	1	1 chunk	+0 lines, -5 lines	0 comments	Download
M	base/timer.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	net/socket/client_socket_pool_base_unittest.cc	View	1	3 chunks	+11 lines, -28 lines	0 comments	Download
M	net/socket/socket_test_util.cc	View	1	1 chunk	+0 lines, -9 lines	0 comments	Download
M	webkit/glue/webkitclient_impl.cc	View	1	2 chunks	+2 lines, -14 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Markus (顧孟勤)

11 years, 3 months ago (2009-09-25 01:10:11 UTC) #3

The try bots didn't show any of these problems, and I have difficulties
reproducing the failures on my desktop. But I'll keep poking at it.

So, yes, for now. Let's assume that these are genuine failures and rollback the
changelist.

I believe, only the valgrind tests on Linux are affected. Please correct me, if
other tests fail too.

Expand Messages | Collapse Messages