Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Issue 2218003: ARM: Default to use unaligned accesses in the simulator... (Closed)

Created:
10 years, 7 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

ARM: Default to use unaligned accesses in the simulator Support building with or without unaligned accesses by using scons flag simulatorunalignedaccesses. $ scons simulator=arm simulatorunalignedaccesses=off $ scons simulator=arm simulatorunalignedaccesses=on If simulatorunalignedaccesses is not specified (or specified as default) the default is to use unaligned accesses. Committed: http://code.google.com/p/v8/source/detail?r=4737

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -3 lines) Patch
M SConstruct View 1 2 3 chunks +17 lines, -2 lines 0 comments Download
M src/arm/constants-arm.h View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Søren Thygesen Gjesse
10 years, 7 months ago (2010-05-26 11:18:19 UTC) #1
Søren Thygesen Gjesse
Updated change to allow building with or without unaligned accesses through a scons option.
10 years, 7 months ago (2010-05-26 14:42:27 UTC) #2
Erik Corry
LGTM
10 years, 7 months ago (2010-05-26 15:03:05 UTC) #3
Erik Corry
Actually, can we just call the flag unalignedaccesses and have it for all ARM targets ...
10 years, 7 months ago (2010-05-26 15:03:58 UTC) #4
Søren Thygesen Gjesse
10 years, 7 months ago (2010-05-27 07:30:57 UTC) #5
On 2010/05/26 15:03:58, Erik Corry wrote:
> Actually, can we just call the flag unalignedaccesses and have it for all ARM
> targets in the scons file?

Good point. Renamed to just unalignedaccesses and check it when arch=arm (which
is also the case when using the simulator).

Powered by Google App Engine
This is Rietveld 408576698