Add kMDItemWhereFroms metadata attribute to downloaded files. Combine with qu...

Add kMDItemWhereFroms metadata attribute to downloaded files. Combine with quarantine utility function and move into chrome/browser/cocoa, since common/ is not the right place for browser code.
BUG=22289
TEST=file downloading

[Avi (use Gerrit), 2009-09-24 21:47:16]

http://codereview.chromium.org/220037/diff/1/4
File chrome/browser/download/download_file.cc (right):

http://codereview.chromium.org/220037/diff/1/4#newcode31
Line 31: #include "chrome/browser/cocoa//file_metadata.h"
//?

[Mark Mentovai, 2009-09-24 22:07:28]

lgtm, if you're into patch-cest

http://codereview.chromium.org/220037/diff/1/2
File chrome/browser/cocoa/file_metadata.mm (right):

http://codereview.chromium.org/220037/diff/1/2#newcode17
Line 17: // As of Mac OS X 10.4 ("Tiger"), files can be tagged with metadata
describing
haha

I can't say I remember writing this comment, but reading it back, I know it was
me.

http://codereview.chromium.org/220037/diff/1/2#newcode37
Line 37: const GURL& referrer) {
indento

http://codereview.chromium.org/220037/diff/1/2#newcode50
Line 50: static MDItemSetAttribute_type md_item_set_attributeL_func = NULL;
On the other hand, I do remember writing this.

I have no idea what that L is doing there, though.

http://codereview.chromium.org/220037/diff/1/2#newcode56
Line 56: ::CFBundleGetBundleWithIdentifier(CFSTR("com.apple.Metadata"));
Since we're moving this into Chromium code, we don't usually use ::.

Also, this will only work if the metadata bundle is already loaded (which it
probably will be.)

http://codereview.chromium.org/220037/diff/1/2#newcode72
Line 72: MDItemRef md_item = ::MDItemCreate(NULL, (CFStringRef)file_path);
scoped_cftyperef?

Also, casts should be C++-style in Chromium.  Line 90 too.

http://codereview.chromium.org/220037/diff/1/2#newcode101
Line 101: FSRef file_ref;
heh, memories here too.

[pink (ping after 24hrs), 2009-09-25 17:35:38]

Updated CL, please re-review.

http://codereview.chromium.org/220037/diff/1/2
File chrome/browser/cocoa/file_metadata.mm (right):

http://codereview.chromium.org/220037/diff/1/2#newcode37
Line 37: const GURL& referrer) {
On 2009/09/24 22:07:28, Mark Mentovai wrote:
> indento

Done.

http://codereview.chromium.org/220037/diff/1/2#newcode50
Line 50: static MDItemSetAttribute_type md_item_set_attributeL_func = NULL;
On 2009/09/24 22:07:28, Mark Mentovai wrote: 
> I have no idea what that L is doing there, though.

A side-effect of converting camelCase to underscores, complete with typo, copy
and pasted.

http://codereview.chromium.org/220037/diff/1/2#newcode56
Line 56: ::CFBundleGetBundleWithIdentifier(CFSTR("com.apple.Metadata"));
On 2009/09/24 22:07:28, Mark Mentovai wrote:
> Since we're moving this into Chromium code, we don't usually use ::.
> 
> Also, this will only work if the metadata bundle is already loaded (which it
> probably will be.)

Done.

http://codereview.chromium.org/220037/diff/1/2#newcode72
Line 72: MDItemRef md_item = ::MDItemCreate(NULL, (CFStringRef)file_path);
On 2009/09/24 22:07:28, Mark Mentovai wrote:
> scoped_cftyperef?
> 
> Also, casts should be C++-style in Chromium.  Line 90 too.

Done.

http://codereview.chromium.org/220037/diff/1/4
File chrome/browser/download/download_file.cc (right):

http://codereview.chromium.org/220037/diff/1/4#newcode31
Line 31: #include "chrome/browser/cocoa//file_metadata.h"
On 2009/09/24 21:47:16, Avi wrote:
> //?

Done.