Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 220026: Preparing for webkit chromium port fork (Closed)

Created:
11 years, 3 months ago by yaar
Modified:
9 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews_googlegroups.com, dglazkov
Visibility:
Public.

Description

Downstreamed v8 extension building & webkit_chromium_port flag 1. Downstreamed building webkit/extension/v8/*.cc files, which were built by upstream webcore by mistake. Now glue will build them. I tested that even though webcore still builds them, there are no errors if glue also builds them. 2. Added webkit_chromium_port variable to build/common.gypi which is turned off by default. Currently, nothing uses it but the chrome port will need it. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27122

Patch Set 1 #

Total comments: 1

Patch Set 2 : renamed variable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M build/common.gypi View 1 2 chunks +6 lines, -0 lines 0 comments Download
M webkit/webkit.gyp View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
yaar
Chromium side of the fork. Thanks!
11 years, 3 months ago (2009-09-24 17:09:35 UTC) #1
Mark Mentovai
lgo http://codereview.chromium.org/220026/diff/1/2 File build/common.gypi (right): http://codereview.chromium.org/220026/diff/1/2#newcode53 Line 53: # This variable tells WebCore.gyp and JavaScriptCore.gyp ...
11 years, 3 months ago (2009-09-24 17:13:34 UTC) #2
yaar
renamed variable
11 years, 3 months ago (2009-09-24 19:27:45 UTC) #3
Mark Mentovai
11 years, 3 months ago (2009-09-24 19:30:13 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698