Issue 220002: Initialize user_gesture_observed_ in NavigationController constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 220002: Initialize user_gesture_observed_ in NavigationController constructor. (Closed)

Created:
11 years, 3 months ago by mattm

Modified:
9 years, 7 months ago

Reviewers:
Yuzo

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Initialize user_gesture_observed_ in NavigationController constructor. BUG=18268 TEST=run the included test under valgrind without the navigation_controller.cc change, then with. The memcheck condititional jump error shouldn't fire with the fix. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27105

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -7 lines)			Patch
M	chrome/browser/tab_contents/navigation_controller.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/tab_contents/navigation_controller_unittest.cc	View	1 chunk	+44 lines, -0 lines	0 comments	Download
M	tools/valgrind/memcheck/suppressions.txt	View	1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Thank you very much for the fix!

Yuzo

Expand Messages | Collapse Messages