Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3311)

Unified Diff: chrome/browser/android/ntp/ntp_snippets_bridge.cc

Issue 2194433002: Zine: support multiple sections in the ui (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cleanups. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/ntp/ntp_snippets_bridge.cc
diff --git a/chrome/browser/android/ntp/ntp_snippets_bridge.cc b/chrome/browser/android/ntp/ntp_snippets_bridge.cc
index 5f9cbf85b7f411f2d3751301aee002ac1df9f7ea..db56daf5ad6ed6ee63b10ecc035ba1a1ae52f37d 100644
--- a/chrome/browser/android/ntp/ntp_snippets_bridge.cc
+++ b/chrome/browser/android/ntp/ntp_snippets_bridge.cc
@@ -126,9 +126,10 @@ void NTPSnippetsBridge::SnippetVisited(JNIEnv* env,
}
int NTPSnippetsBridge::GetCategoryStatus(JNIEnv* env,
- const JavaParamRef<jobject>& obj) {
+ const JavaParamRef<jobject>& obj,
+ jint category) {
return static_cast<int>(content_suggestions_service_->GetCategoryStatus(
- ContentSuggestionsCategory::ARTICLES));
+ static_cast<ContentSuggestionsCategory>(category)));
}
NTPSnippetsBridge::~NTPSnippetsBridge() {}
@@ -176,8 +177,11 @@ void NTPSnippetsBridge::OnNewSuggestions() {
}
JNIEnv* env = base::android::AttachCurrentThread();
- Java_SnippetsBridge_onSnippetsAvailable(
- env, observer_.obj(), ToJavaArrayOfStrings(env, ids).obj(),
+ // TODO(mvanouwerkerk): Do not hard code ARTICLES.
+ Java_SnippetsBridge_onSuggestionsAvailable(
+ env, observer_.obj(),
+ static_cast<int>(ContentSuggestionsCategory::ARTICLES),
+ ToJavaArrayOfStrings(env, ids).obj(),
ToJavaArrayOfStrings(env, titles).obj(),
ToJavaArrayOfStrings(env, urls).obj(),
ToJavaArrayOfStrings(env, amp_urls).obj(),
@@ -190,11 +194,13 @@ void NTPSnippetsBridge::OnNewSuggestions() {
void NTPSnippetsBridge::OnCategoryStatusChanged(
ContentSuggestionsCategory category,
ContentSuggestionsCategoryStatus new_status) {
+ // TODO(mvanouwerkerk): Do not hard code ARTICLES.
if (category != ContentSuggestionsCategory::ARTICLES)
return;
JNIEnv* env = base::android::AttachCurrentThread();
Java_SnippetsBridge_onCategoryStatusChanged(env, observer_.obj(),
+ static_cast<int>(category),
static_cast<int>(new_status));
}

Powered by Google App Engine
This is Rietveld 408576698