components/ntp_snippets/content_suggestions_category.h - Issue 2194433002: Zine: support multiple sections in the ui

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/ntp_snippets/content_suggestions_category.h

Issue 2194433002: Zine: support multiple sections in the ui (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleanups. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef COMPONENTS_NTP_SNIPPETS_CONTENT_SUGGESTIONS_CATEGORY_H_	5 #ifndef COMPONENTS_NTP_SNIPPETS_CONTENT_SUGGESTIONS_CATEGORY_H_

6 #define COMPONENTS_NTP_SNIPPETS_CONTENT_SUGGESTIONS_CATEGORY_H_	6 #define COMPONENTS_NTP_SNIPPETS_CONTENT_SUGGESTIONS_CATEGORY_H_

7	7

8 namespace ntp_snippets {	8 namespace ntp_snippets {

9	9

10 // A category groups ContentSuggestions which belong together.	10 // A category groups ContentSuggestions which belong together.

11 enum class ContentSuggestionsCategory { ARTICLES, OFFLINE_PAGES, COUNT };	11 // On Android builds, a Java counterpart will be generated for this enum.

	12 // GENERATED_JAVA_ENUM_PACKAGE: org.chromium.chrome.browser.ntp.snippets

	13 enum class ContentSuggestionsCategory {

	14 // Articles for you.

	15 ARTICLES,

	16

	17 // Downloaded pages.

	18 OFFLINE_PAGES,

	19

	20 // Enum count for ??? reasons.

	21 COUNT
	PEConn 2016/07/29 10:01:43 I think the convention is to have the last element I think the convention is to have the last element called MAX, eg: https://cs.chromium.org/chromium/src/components/signin/core/browser/signin_me... Bernhard Bauer 2016/08/01 15:01:34 MAX would be the maximum allowed value, which woul Show quoted text On 2016/07/29 10:01:43, PEConn1 wrote: > I think the convention is to have the last element called MAX, eg: > https://cs.chromium.org/chromium/src/components/signin/core/browser/signin_me... MAX would be the maximum allowed value, which would really be OFFLINE_PAGES in this case :)
	22 };

12	23

13 } // namespace ntp_snippets	24 } // namespace ntp_snippets

14	25

15 #endif // COMPONENTS_NTP_SNIPPETS_CONTENT_SUGGESTIONS_CATEGORY_H_	26 #endif // COMPONENTS_NTP_SNIPPETS_CONTENT_SUGGESTIONS_CATEGORY_H_

OLD	NEW

« chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SuggestionsCategoryStatus.java ('K') | « components/ntp_snippets/BUILD.gn ('k') | no next file » | no next file with comments »