linux: drop temp_scaffolding_stubs

linux: drop temp_scaffolding_stubs

It was mostly unneeded, but I had to excise the last bits of RLZ and move
some NOTIMPLEMENTED bits to where they belong.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27161

[Evan Martin, 2009-09-25 01:03:02]

assuming this passes trybots plz review

[Evan Stade, 2009-09-25 01:07:23]

LGTM. Quick sanity check: does it work if you do

#if defined(OS_LINUX)
#error
#endif

in temp_scaffolding_stubs.h?

http://codereview.chromium.org/219042/diff/1/4
File chrome/browser/download/download_util.cc (right):

http://codereview.chromium.org/219042/diff/1/4#newcode291
Line 291: void DragDownload(const DownloadItem* download,
I don't understand why this exists. Seems to be for the dom ui. But I would
think we ought to be using normal webkit/html5 drags as we do on the new tab
page.

(idle thoughts)

http://codereview.chromium.org/219042/diff/1/6
File chrome/browser/search_engines/template_url.cc (right):

http://codereview.chromium.org/219042/diff/1/6#newcode304
Line 304: #if defined(OS_WIN)
move defines outside of case?

[Evan Martin, 2009-09-25 01:10:54]

On 2009/09/25 01:07:23, Evan Stade wrote:
> LGTM. Quick sanity check: does it work if you do
> 
> #if defined(OS_LINUX)
> #error
> #endif
> 
> in temp_scaffolding_stubs.h?

views still needs the file.  :\

> http://codereview.chromium.org/219042/diff/1/4
> File chrome/browser/download/download_util.cc (right):
> 
> http://codereview.chromium.org/219042/diff/1/4#newcode291
> Line 291: void DragDownload(const DownloadItem* download,
> I don't understand why this exists. Seems to be for the dom ui. But I would
> think we ought to be using normal webkit/html5 drags as we do on the new tab
> page.
> 
> (idle thoughts)

Dunno, I guess it's related to dragging files.

> http://codereview.chromium.org/219042/diff/1/6
> File chrome/browser/search_engines/template_url.cc (right):
> 
> http://codereview.chromium.org/219042/diff/1/6#newcode304
> Line 304: #if defined(OS_WIN)
> move defines outside of case?

No, we need them there, so that we replace RLZ in the query string with empty
string

[tony, 2009-09-25 01:11:39]

LG

http://codereview.chromium.org/219042/diff/1/8
File chrome/chrome.gyp (right):

http://codereview.chromium.org/219042/diff/1/8#newcode644
Line 644: 'common/temp_scaffolding_stubs.cc',
linux views?

[Evan Stade, 2009-09-25 01:15:14]

On Thu, Sep 24, 2009 at 6:10 PM,  <evan@chromium.org> wrote:
> On 2009/09/25 01:07:23, Evan Stade wrote:
>>
>> LGTM. Quick sanity check: does it work if you do
>
>> #if defined(OS_LINUX)
>> #error
>> #endif
>
>> in temp_scaffolding_stubs.h?
>
> views still needs the file. =A0:\

so we are still including it on TOOLKIT_GTK? that could lead to confusion

>
>> http://codereview.chromium.org/219042/diff/1/4
>> File chrome/browser/download/download_util.cc (right):
>
>> http://codereview.chromium.org/219042/diff/1/4#newcode291
>> Line 291: void DragDownload(const DownloadItem* download,
>> I don't understand why this exists. Seems to be for the dom ui. But I
>> would
>> think we ought to be using normal webkit/html5 drags as we do on the new
>> tab
>> page.
>
>> (idle thoughts)
>
> Dunno, I guess it's related to dragging files.
>
>> http://codereview.chromium.org/219042/diff/1/6
>> File chrome/browser/search_engines/template_url.cc (right):
>
>> http://codereview.chromium.org/219042/diff/1/6#newcode304
>> Line 304: #if defined(OS_WIN)
>> move defines outside of case?
>
> No, we need them there, so that we replace RLZ in the query string with
> empty
> string

k I don't understand that but if we intend to fall through, could you
put a comment to that effect?

[Evan Stade, 2009-09-25 19:54:41]

http://codereview.chromium.org/219042/diff/1/6
File chrome/browser/search_engines/template_url.cc (right):

http://codereview.chromium.org/219042/diff/1/6#newcode312
Line 312: #endif
still seems like this endif should come before the break;

[Evan Martin, 2009-09-25 20:00:14]

On Fri, Sep 25, 2009 at 12:54 PM,  <estade@chromium.org> wrote:
>
> http://codereview.chromium.org/219042/diff/1/6
> File chrome/browser/search_engines/template_url.cc (right):
>
> http://codereview.chromium.org/219042/diff/1/6#newcode312
> Line 312: #endif
> still seems like this endif should come before the break;

Doh.  Will fix.