Issue 219037: Changes the main menu to do the following:...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 219037: Changes the main menu to do the following:... (Closed)

Created:
11 years, 3 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews_googlegroups.com, brettw, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Changes the main menu to do the following: . Creates a TabContents in CreateNewWindow rather than a RenderViewHost. We want to support the ability to open popups from this menu, so going with TabContents directly seemed the best option. . Showing the menu now does a keyboard grab. This is needed so that keyboard events go to the menu and focus doesn't remain whever it was when the menu was shown. BUG=22954 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27179

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+130 lines, -41 lines)			Patch
M	chrome/browser/chromeos/main_menu.h	View	5 chunks	+66 lines, -16 lines	0 comments	Download
M	chrome/browser/chromeos/main_menu.cc	View	4 chunks	+63 lines, -24 lines	0 comments	Download
M	chrome/browser/tab_contents/render_view_host_delegate_helper.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages