Chromium Code Reviews

Unified Diff: webkit/webkit.gyp

Issue 219007: Rolling back 26904, didn't take chrome branding into account.... (Closed) Base URL: svn://chrome-svn.corp.google.com/chrome/trunk/src/
Patch Set: Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« no previous file with comments | « webkit/tools/test_shell/test_shell.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/webkit.gyp
===================================================================
--- webkit/webkit.gyp (revision 26904)
+++ webkit/webkit.gyp (working copy)
@@ -8,10 +8,7 @@
],
'variables': {
# TODO: remove this helper when we have loops in GYP
- 'apply_locales_cmd': ['python', '../chrome/tools/build/apply_locales.py'],
- 'grit_info_cmd': ['python', '../tools/grit/grit_info.py'],
- 'grit_cmd': ['python', '../tools/grit/grit.py'],
- 'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/webkit',
+ 'apply_locales_cmd': ['python', '../chrome/tools/build/apply_locales.py',],
# We can't turn on warnings on Windows and Linux until we upstream the
# WebKit API.
@@ -246,6 +243,10 @@
'target_name': 'webkit_resources',
'type': 'none',
'msvs_guid': '0B469837-3D46-484A-AFB3-C5A6C68730B9',
+ 'variables': {
+ 'grit_path': '../tools/grit/grit.py',
+ 'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/webkit',
+ },
'actions': [
{
'action_name': 'webkit_resources',
@@ -253,19 +254,20 @@
'input_path': 'glue/webkit_resources.grd',
},
'inputs': [
- '<!@(<(grit_info_cmd) --inputs <(input_path))',
+ '<(input_path)',
],
'outputs': [
- '<!@(<(grit_info_cmd) --outputs \'<(grit_out_dir)/webkit_resources\' <(input_path))',
+ '<(grit_out_dir)/grit/webkit_resources.h',
+ '<(grit_out_dir)/webkit_resources.pak',
+ '<(grit_out_dir)/webkit_resources.rc',
],
- 'action': ['<@(grit_cmd)', '-i', '<(input_path)', 'build',
- '-o', '<(grit_out_dir)/webkit_resources'],
+ 'action': ['python', '<(grit_path)', '-i', '<(input_path)', 'build', '-o', '<(grit_out_dir)'],
'message': 'Generating resources from <(input_path)',
},
],
'direct_dependent_settings': {
'include_dirs': [
- '<(grit_out_dir)/webkit_resources',
+ '<(SHARED_INTERMEDIATE_DIR)/webkit',
],
},
'conditions': [
@@ -278,6 +280,10 @@
'target_name': 'webkit_strings',
'type': 'none',
'msvs_guid': '60B43839-95E6-4526-A661-209F16335E0E',
+ 'variables': {
+ 'grit_path': '../tools/grit/grit.py',
+ 'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/webkit',
+ },
'actions': [
{
'action_name': 'webkit_strings',
@@ -285,19 +291,20 @@
'input_path': 'glue/webkit_strings.grd',
},
'inputs': [
- '<!@(<(grit_info_cmd) --inputs <(input_path))',
+ '<(input_path)',
],
'outputs': [
- '<!@(<(grit_info_cmd) --outputs \'<(grit_out_dir)/webkit_strings\' <(input_path))',
+ '<(grit_out_dir)/grit/webkit_strings.h',
+ # TODO: remove this helper when we have loops in GYP
+ '>!@(<(apply_locales_cmd) \'<(grit_out_dir)/webkit_strings_ZZLOCALE.pak\' <(locales))',
],
- 'action': ['<@(grit_cmd)', '-i', '<(input_path)', 'build',
- '-o', '<(grit_out_dir)/webkit_strings'],
+ 'action': ['python', '<(grit_path)', '-i', '<(input_path)', 'build', '-o', '<(grit_out_dir)'],
'message': 'Generating resources from <(input_path)',
},
],
'direct_dependent_settings': {
'include_dirs': [
- '<(grit_out_dir)/webkit_strings',
+ '<(SHARED_INTERMEDIATE_DIR)/webkit',
],
},
'conditions': [
« no previous file with comments | « webkit/tools/test_shell/test_shell.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine