Issue 2189001: Add real gclient_smoke tests now

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2189001: Add real gclient_smoke tests now (Closed)

Created:
10 years, 7 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Nasser Grainawi, yaar

CC:
chromium-reviews

Visibility:
Public.

Description

Add real gclient_smoke tests now gclient sync, revert and status are tested. GClientSmokeGIT.testRevertAndStatus is known to fail since git-backed revert doesn't work. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48239

Patch Set 1 #

Total comments: 2

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+465 lines, -118 lines)			Patch
	M	tests/fake_repos.py	View		5 chunks	+243 lines, -96 lines	0 comments	Download
	M	tests/gclient_smoketest.py	View		6 chunks	+222 lines, -22 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

yaar1

LGTM, though I'm not too familiar with the code base. http://codereview.chromium.org/2189001/diff/1/3 File tests/gclient_smoketest.py (right): http://codereview.chromium.org/2189001/diff/1/3#newcode249 ...

10 years, 7 months ago (2010-05-26 01:37:24 UTC) #2

M-A Ruel

10 years, 7 months ago (2010-05-26 01:56:02 UTC) #3

http://codereview.chromium.org/2189001/diff/1/3
File tests/gclient_smoketest.py (right):

http://codereview.chromium.org/2189001/diff/1/3#newcode249
tests/gclient_smoketest.py:249: results = self.gclient(['sync', '--deps',
'mac'])
On 2010/05/26 01:37:24, yaar1 wrote:
> Is this only going to work on Mac?

No but I'm enforcing the platform so the test behaves consistently on every
platforms.

Expand Messages | Collapse Messages