Linux: work around browser windows that get stuck maximized by the WM.

Linux: work around browser windows that get stuck maximized by the WM.
BUG=22807
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27247

[Evan Stade, 2009-09-25 01:38:29]

lgtm, maybe ping tony to take a look as well?

[tony, 2009-09-25 17:42:11]

Can't we get unmaximize from other places like from the window manager?  Is it
possible for us to do something when we get the window state changed event or is
that too late?

[Mike Mammarella, 2009-09-25 17:58:44]

The problem is that the window manager doesn't seem to actually think we're
restoring. We ask it to, but all we get is a a reconfigure event for the same
size we already are and we stay maximized.

On 2009/09/25 17:42:11, tony wrote:
> Can't we get unmaximize from other places like from the window manager?  Is it
> possible for us to do something when we get the window state changed event or
is
> that too late?

[tony, 2009-09-25 18:03:21]

On 2009/09/25 17:58:44, Mike Mammarella wrote:
> The problem is that the window manager doesn't seem to actually think we're
> restoring. We ask it to, but all we get is a a reconfigure event for the same
> size we already are and we stay maximized.

Can we do something when we get the reconfigure event for the same size on a
maximized window that matches the full screen size?  I.e., it seems like we
still have the bug if the user uses the window manager.

[Mike Mammarella, 2009-09-25 18:31:48]

It turns out you can't reliably compare against the full screen size: GDK tells
us the actual size of the screen, but depending on what panels you have docked
on the screen, the size that the window manager considers to be "maximized" may
be less. I tried a few variations on that before getting to this approach.

We also can't seem to reliably use the reconfigure event to figure out whether
we appear to be restoring to the same size we were when maximized, because when
we truly do restore to a non-maximized size the reconfigure event and EWMH state
change may arrive in either order. (That was the cause of bug 15102.)

Fortunately this is probably only an issue when using the custom frame anyway:
when using the system decorations, it seems you can resize a window even while
it's maximized. At least, you can in kwin when you have multiple displays. (It
doesn't actually draw the windows with maximized decorations, so that you can
still resize them.)

On 2009/09/25 18:03:21, tony wrote:
> On 2009/09/25 17:58:44, Mike Mammarella wrote:
> > The problem is that the window manager doesn't seem to actually think we're
> > restoring. We ask it to, but all we get is a a reconfigure event for the
same
> > size we already are and we stay maximized.
> 
> Can we do something when we get the reconfigure event for the same size on a
> maximized window that matches the full screen size?  I.e., it seems like we
> still have the bug if the user uses the window manager.

[tony, 2009-09-25 20:21:02]

Ok, LGTM