Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: src/ia32/macro-assembler-ia32.cc

Issue 218025: Rename JumpToBuiltin to JumpToRuntime. Add comment to ResolveBuiltin. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/macro-assembler-ia32.h ('k') | src/x64/builtins-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2009 the V8 project authors. All rights reserved. 1 // Copyright 2006-2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 885 matching lines...) Expand 10 before | Expand all | Expand 10 after
896 896
897 897
898 void MacroAssembler::TailCallRuntime(const ExternalReference& ext, 898 void MacroAssembler::TailCallRuntime(const ExternalReference& ext,
899 int num_arguments, 899 int num_arguments,
900 int result_size) { 900 int result_size) {
901 // TODO(1236192): Most runtime routines don't need the number of 901 // TODO(1236192): Most runtime routines don't need the number of
902 // arguments passed in because it is constant. At some point we 902 // arguments passed in because it is constant. At some point we
903 // should remove this need and make the runtime routine entry code 903 // should remove this need and make the runtime routine entry code
904 // smarter. 904 // smarter.
905 Set(eax, Immediate(num_arguments)); 905 Set(eax, Immediate(num_arguments));
906 JumpToBuiltin(ext); 906 JumpToRuntime(ext);
907 } 907 }
908 908
909 909
910 void MacroAssembler::JumpToBuiltin(const ExternalReference& ext) { 910 void MacroAssembler::JumpToRuntime(const ExternalReference& ext) {
911 // Set the entry point and jump to the C entry runtime stub. 911 // Set the entry point and jump to the C entry runtime stub.
912 mov(ebx, Immediate(ext)); 912 mov(ebx, Immediate(ext));
913 CEntryStub ces(1); 913 CEntryStub ces(1);
914 jmp(ces.GetCode(), RelocInfo::CODE_TARGET); 914 jmp(ces.GetCode(), RelocInfo::CODE_TARGET);
915 } 915 }
916 916
917 917
918 void MacroAssembler::InvokePrologue(const ParameterCount& expected, 918 void MacroAssembler::InvokePrologue(const ParameterCount& expected,
919 const ParameterCount& actual, 919 const ParameterCount& actual,
920 Handle<Code> code_constant, 920 Handle<Code> code_constant,
(...skipping 262 matching lines...) Expand 10 before | Expand all | Expand 10 after
1183 // Indicate that code has changed. 1183 // Indicate that code has changed.
1184 CPU::FlushICache(address_, size_); 1184 CPU::FlushICache(address_, size_);
1185 1185
1186 // Check that the code was patched as expected. 1186 // Check that the code was patched as expected.
1187 ASSERT(masm_.pc_ == address_ + size_); 1187 ASSERT(masm_.pc_ == address_ + size_);
1188 ASSERT(masm_.reloc_info_writer.pos() == address_ + size_ + Assembler::kGap); 1188 ASSERT(masm_.reloc_info_writer.pos() == address_ + size_ + Assembler::kGap);
1189 } 1189 }
1190 1190
1191 1191
1192 } } // namespace v8::internal 1192 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ia32/macro-assembler-ia32.h ('k') | src/x64/builtins-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698