Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1375)

Side by Side Diff: src/arm/macro-assembler-arm.cc

Issue 218025: Rename JumpToBuiltin to JumpToRuntime. Add comment to ResolveBuiltin. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/macro-assembler-arm.h ('k') | src/ia32/builtins-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2009 the V8 project authors. All rights reserved. 1 // Copyright 2006-2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 983 matching lines...) Expand 10 before | Expand all | Expand 10 after
994 994
995 995
996 void MacroAssembler::TailCallRuntime(const ExternalReference& ext, 996 void MacroAssembler::TailCallRuntime(const ExternalReference& ext,
997 int num_arguments, 997 int num_arguments,
998 int result_size) { 998 int result_size) {
999 // TODO(1236192): Most runtime routines don't need the number of 999 // TODO(1236192): Most runtime routines don't need the number of
1000 // arguments passed in because it is constant. At some point we 1000 // arguments passed in because it is constant. At some point we
1001 // should remove this need and make the runtime routine entry code 1001 // should remove this need and make the runtime routine entry code
1002 // smarter. 1002 // smarter.
1003 mov(r0, Operand(num_arguments)); 1003 mov(r0, Operand(num_arguments));
1004 JumpToBuiltin(ext); 1004 JumpToRuntime(ext);
1005 } 1005 }
1006 1006
1007 1007
1008 void MacroAssembler::JumpToBuiltin(const ExternalReference& builtin) { 1008 void MacroAssembler::JumpToRuntime(const ExternalReference& builtin) {
1009 #if defined(__thumb__) 1009 #if defined(__thumb__)
1010 // Thumb mode builtin. 1010 // Thumb mode builtin.
1011 ASSERT((reinterpret_cast<intptr_t>(builtin.address()) & 1) == 1); 1011 ASSERT((reinterpret_cast<intptr_t>(builtin.address()) & 1) == 1);
1012 #endif 1012 #endif
1013 mov(r1, Operand(builtin)); 1013 mov(r1, Operand(builtin));
1014 CEntryStub stub(1); 1014 CEntryStub stub(1);
1015 Jump(stub.GetCode(), RelocInfo::CODE_TARGET); 1015 Jump(stub.GetCode(), RelocInfo::CODE_TARGET);
1016 } 1016 }
1017 1017
1018 1018
(...skipping 156 matching lines...) Expand 10 before | Expand all | Expand 10 after
1175 } 1175 }
1176 1176
1177 1177
1178 void CodePatcher::Emit(Address addr) { 1178 void CodePatcher::Emit(Address addr) {
1179 masm()->emit(reinterpret_cast<Instr>(addr)); 1179 masm()->emit(reinterpret_cast<Instr>(addr));
1180 } 1180 }
1181 #endif // ENABLE_DEBUGGER_SUPPORT 1181 #endif // ENABLE_DEBUGGER_SUPPORT
1182 1182
1183 1183
1184 } } // namespace v8::internal 1184 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/macro-assembler-arm.h ('k') | src/ia32/builtins-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698