Issue 218015: Don't add default Accept-Language and Accept-Charset headers if specific ones...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 218015: Don't add default Accept-Language and Accept-Charset headers if specific ones... (Closed)

Created:
11 years, 3 months ago by Dmitry Titov

Modified:
9 years, 7 months ago

Reviewers:
eroman

CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org, tim (not reviewing), Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Don't add default Accept-Language and Accept-Charset headers if specific ones were set in URLRequest BUG=20894 TEST=enabled layout test LayoutTests/http/tests/xmlhttprequest/access-control-basic-whitelist-request-headers.html Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27090

Patch Set 1 #

Total comments: 1

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+72 lines, -7 lines)			Patch
M	net/url_request/url_request_http_job.cc	View	2 chunks	+21 lines, -6 lines	1 comment	Download
M	net/url_request/url_request_unittest.cc	View	2 chunks	+51 lines, -0 lines	0 comments	Download
M	webkit/tools/layout_tests/test_expectations.txt	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Dmitry Titov

This is a continuation of the review from http://codereview.chromium.org/213010 (I've moved to the new machine ...

11 years, 3 months ago (2009-09-24 01:42:53 UTC) #1

eroman

11 years, 3 months ago (2009-09-24 02:19:32 UTC) #2

LGTM!

http://codereview.chromium.org/218015/diff/1/3
File net/url_request/url_request_http_job.cc (right):

http://codereview.chromium.org/218015/diff/1/3#newcode660
Line 660: // didn't have them specifically specified.
nit: slightly redundant wording; can probably omit "specifically".

Expand Messages | Collapse Messages