Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 218010: Reland: Linux (nss) implementations of RSAPrivateKey and SignatureCreator (Closed)

Created:
11 years, 3 months ago by rafaelw
Modified:
9 years, 7 months ago
Reviewers:
wtc
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Reland: Linux (nss) implementations of RSAPrivateKey and SignatureCreator. This relands: http://codereview.chromium.org/208032. Additionally, it fixes a memleak unconvered by valgrind, and adds a valgrind supression for a memleak discovered in the nss library. https://bugzilla.mozilla.org/show_bug.cgi?id=518443 BUG=20669 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27033

Patch Set 1 #

Patch Set 2 : fix memleaks #

Total comments: 4

Patch Set 3 : cr changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+347 lines, -14 lines) Patch
M base/base.gyp View 4 chunks +10 lines, -3 lines 0 comments Download
M base/crypto/rsa_private_key.h View 3 chunks +13 lines, -5 lines 0 comments Download
A base/crypto/rsa_private_key_nss.cc View 1 1 chunk +225 lines, -0 lines 0 comments Download
M base/crypto/signature_creator.h View 2 chunks +13 lines, -5 lines 0 comments Download
A base/crypto/signature_creator_nss.cc View 1 chunk +74 lines, -0 lines 0 comments Download
M base/crypto/signature_creator_win.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 2 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
rafaelw
11 years, 3 months ago (2009-09-23 22:27:19 UTC) #1
wtc
LGTM. http://codereview.chromium.org/218010/diff/1001/2007 File tools/valgrind/memcheck/suppressions.txt (right): http://codereview.chromium.org/218010/diff/1001/2007#newcode291 Line 291: https://bugzilla.mozilla.org/show_bug.cgi?id=518443 Please make this a comment: # ...
11 years, 3 months ago (2009-09-23 22:48:56 UTC) #2
rafaelw
http://codereview.chromium.org/218010/diff/1001/2007 File tools/valgrind/memcheck/suppressions.txt (right): http://codereview.chromium.org/218010/diff/1001/2007#newcode291 Line 291: https://bugzilla.mozilla.org/show_bug.cgi?id=518443 On 2009/09/23 22:48:56, wtc wrote: > Please ...
11 years, 3 months ago (2009-09-23 23:01:17 UTC) #3
wtc
11 years, 3 months ago (2009-09-23 23:15:21 UTC) #4
LGTM.

Powered by Google App Engine
This is Rietveld 408576698