Issue 218002: Fixing bug #152 (pressing "T" doens't leave a trail in the particle samples o...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 218002: Fixing bug #152 (pressing "T" doens't leave a trail in the particle samples o...

Created:
11 years, 3 months ago by vangelis

Modified:
11 years, 3 months ago

Reviewers:
apatrick

CC:
o3d-review_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/o3d/

Visibility:
Public.

Description

Fixing bug #152 (pressing "T" doens't leave a trail in the particle samples only in Chrome). The problem had to do with the translation of the key codes. There's another issue that surfaced with the event.js code in IE when the events are handled by methods running in V8. In that situation it appears that event.keyIdentifier isn't actually a string and IE barfs when we call keyIdent.indexOf(). I added a check to make sure it's a string but I don't know if the fix really belongs somewhere in the V8 / IE bridge

Patch Set 1 #

Created: 11 years, 3 months ago

		Unified diffs	Side-by-side diffs	Stats (+6 lines, -6 lines)
	M	samples/o3djs/event.js	View	3 chunks	+4 lines, -4 lines	0 comments
	M	samples/particles.html	View	1 chunk	+2 lines, -2 lines	0 comments

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM for now. I'll investigate the V8 bridge tomorrow.

Expand Messages | Collapse Messages