Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2177001: Merge 58961 - Reviewed by Adele Peterson.... (Closed)

Created:
10 years, 7 months ago by inferno
Modified:
9 years, 7 months ago
Reviewers:
inferno
CC:
chromium-reviews
Visibility:
Public.

Description

Merge 58961 - Reviewed by Adele Peterson. https://bugs.webkit.org/show_bug.cgi?id=38546 Node.focus() fails to move focus from subframe properly Test: fast/frames/takefocusfromiframe.html * html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::setFocus): Don't clear focus if this frame doesn't have it. This can happen if page's and HTMLFrameElement's ideas of focused frame get out of sync temporarily. TBR=ap@apple.com BUG=15766 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48065

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -2 lines) Patch
M LayoutTests/ChangeLog View 1 chunk +12 lines, -0 lines 0 comments Download
A LayoutTests/fast/frames/take-focus-from-iframe.html View 1 chunk +33 lines, -0 lines 0 comments Download
A LayoutTests/platform/mac/fast/frames/take-focus-from-iframe-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A LayoutTests/platform/mac/fast/frames/take-focus-from-iframe-expected.png View Binary file 0 comments Download
A LayoutTests/platform/mac/fast/frames/take-focus-from-iframe-expected.txt View 1 chunk +25 lines, -0 lines 0 comments Download
M WebCore/ChangeLog View 1 chunk +13 lines, -0 lines 0 comments Download
M WebCore/html/HTMLFrameElementBase.cpp View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
inferno
10 years, 7 months ago (2010-05-24 19:27:47 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698