Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 2171002: Merge 59495 - 20100514 Abhishek Arya <inferno@chromium.org>... (Closed)

Created:
10 years, 7 months ago by inferno
Modified:
9 years, 7 months ago
Reviewers:
inferno
CC:
chromium-reviews
Visibility:
Public.

Description

Merge 59495 - 20100514 Abhishek Arya <inferno@chromium.org>; Reviewed by David Hyatt. Tests that large colspan in a fixed table layout does not result in crash. https://bugs.webkit.org/show_bug.cgi?id=38261 * fast/table/fixedtablelayoutlargecolspancrashexpected.txt: Added. * fast/table/fixedtablelayoutlargecolspancrash.html: Added. 20100514 Abhishek Arya <inferno@chromium.org>; Reviewed by David Hyatt. Move the m_width(Length) and m_columns(RenderTable::ColumnStruct) vector outofbounds check out of the ASSERT into the main code. https://bugs.webkit.org/show_bug.cgi?id=38261 Test: fast/table/fixedtablelayoutlargecolspancrash.html * rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::calcWidthArray): BUG=42723 TBR=eric@webkit.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48059

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -2 lines) Patch
M LayoutTests/ChangeLog View 1 chunk +10 lines, -0 lines 0 comments Download
A LayoutTests/fast/table/fixed-table-layout-large-colspan-crash.html View 1 chunk +26 lines, -0 lines 0 comments Download
A LayoutTests/fast/table/fixed-table-layout-large-colspan-crash-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M WebCore/ChangeLog View 1 chunk +13 lines, -0 lines 0 comments Download
M WebCore/rendering/FixedTableLayout.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
inferno
10 years, 7 months ago (2010-05-24 18:25:40 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698